Fix two doc bugs #401
Merged
Fix two doc bugs #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulrnash
commented
Mar 12, 2016
paulrnash
commented
- password_confirmation was listed twice
- Example for ignoring an exception did not match text above it (said 404's, actually showed ignoring RecordNotFound)
1) password_confirmation was listed twice 2) Example for ignoring an exception did not match text above it (said 404's, actually showed ignoring RecordNotFound)
| @@ -434,7 +433,7 @@ If you'd like to customize this list, modify the example code in ```config/initi | |||
|
|
|||
| ```ruby | |||
| config.exception_level_filters.merge!({ | |||
| 'ActiveRecord::RecordNotFound' => 'ignore', | |||
| 'ActionController::RoutingError' => 'ignore', | |||
There was a problem hiding this comment.
Here you changed a not related line
There was a problem hiding this comment.
No, please see the PR comment. This was the second doc bug I fixed. See how the doc text says "to ignore 404 errors..." and then the example is for RecordNotFound instead. Expand the context more at line 432 to see why the example is incorrect.
There was a problem hiding this comment.
Oh, sorry, you are right. I think the comment is confusing but right at same time, since if you raise a ActiveRecord::RecordNotFound exception in Rails you will have a 404 response code. I'll check this.
There was a problem hiding this comment.
Ah, that may be true... but def not the only source of a 404. It kind of
depends on what you catch and/or coerce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.