Mock the requests to Rollbar API #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working and developing in the gem using real requests to the API becomes a nightmare when there are some connection issues. The tests fails in Travis and we loose a lot of time rebuilding the failed jobs.
With this change we mock all the requests to a mocked Rollbar API. Since for now the tests only expect to receive 200 codes, the mock API just return 200 codes with the expected response body. This can be changed in the future easier.
The time to run the tests now is between 1.5s and 2s. Not the build in travis that needs to run bundle install, etc...
For Ruby 1.8.7 and Ruby 1.9.2 we cannot install webmock. This is a nother smell that we should start thinking in stop official support for those Rubies at some point.