Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub keys from hash arguments #570

Closed
wants to merge 2 commits into from
Closed

Scrub keys from hash arguments #570

wants to merge 2 commits into from

Conversation

aabes
Copy link

@aabes aabes commented Feb 24, 2017

This is an attempt to filter out large elements from a body of a POST message, that rollbar is attempting to post in the content of an error.

The environment is a rack app (running in puma). A post request with a structure similar to below causes an error -

 {
   "foo": 1,
   "blob": "very large data"
 }
 

The rollbar configuration has:

config.scrub_fields = [:blob]

but despite that, blob is included in the payload (and posting the error fails due to size).

This PR ensures that the hash keys included in the scrub_fields are excluded from the payload.

Does this ring right?

@rokob
Copy link
Contributor

rokob commented Feb 24, 2017

I am going to close this because #567 which was just merged solves this problem.

@rokob rokob closed this Feb 24, 2017
@aabes
Copy link
Author

aabes commented Feb 27, 2017

@rokob - what version of the gem will this equivalent PR be available in (i.e. I want to switch away from my fork back to a supported version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants