Skip to content

Conversation

danielmorell
Copy link
Collaborator

Description of the change

Removed the need for a new session to be created on every request. This is an antipattern and can cause issues. This was only used for "flash" messages. Most instances have been replaced with WP notices.

Type of change

Bug fix (non-breaking change that fixes an issue)

Related issues

Fix #85

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell requested a review from cyrusradfar June 6, 2022 21:06
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

@danielmorell danielmorell merged commit 4837aa9 into next/2.6.4 Jun 7, 2022
@danielmorell danielmorell deleted the fixed_85 branch June 7, 2022 10:44
@danielmorell danielmorell added this to the v2.6.4 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants