fix(initPhpLogging): Moving fetch settings to before settings check. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is the bug that you cannot disable PhpLogging since the settings property is not set until fetchSettings() is called. So I reordered.
|
LGTM :) I'll try to get this released in the next couple of days |
|
Thank you @ArturMoczulski for merging my change, but can we get an updated plugin release soon? It has been months and other issues are being opened for problems already resolved. See #91 |
|
Yeah. I’ll try to get this released this weekend
|
|
This has been now released in https://github.com/rollbar/rollbar-php-wordpress/releases/tag/v2.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the bug that you cannot disable PhpLogging since the settings
property is not set until fetchSettings() is called. So I reordered.