fix: correct PHP notice on register-rest-route in WordPress v5.5.0 #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this! |
bishopb
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Thanks for your contribution, @rkaiser0324! Manual testing confirms fix for WordPress 5.5+ without impact to behavior on WordPress 5.0 to 5.4. We'll forgo a test on this specific change as it's documented as part of the WordPress plugin specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of WordPress 5.5.0 the
permission_callbackis required, or you get this:Notice: register_rest_route was called incorrectly. The REST API route definition for
rollbar/v1/test-php-loggingis missing the requiredpermission_callbackargument. For REST API routes that are intended to be public, use__return_trueas the permission callback. Please see Debugging in WordPress for more information. (This message was added in version 5.5.0.)This fixes that.