Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize eslint and prettier for the entire project with ci checks #110

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 24, 2024

Description of the change

This PR opinionatedly declares eslint as the default linter for rollbar-react, and prettier the default formatter, as is in Olympus.

The same formatting configuration as Olympus has been used and the build CI has been rewritten with updated actions, caching and a linting step that runs eslint and prettier.

Eslint configuration for each example has been made its own root eslint configuration to avoid grabbing the library's eslint config which defines plugins incompatible with apps.

Eslint ignore file has been added to avoid eslint linting the dist directory, and others.


Linting and format checks are disabled for now, so I can do the linting and formatting on separate PRs to keep the size of them and their reviewability in check.


Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Feb 24, 2024
@matux matux force-pushed the matux/eslint-prettier-config branch from 0763cf8 to 139471c Compare February 26, 2024 16:41
@matux matux force-pushed the matux/eslint-prettier-config branch from 139471c to 53c061c Compare February 26, 2024 16:45
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small items here but nothing major

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@matux matux requested a review from mudetroit February 26, 2024 17:56
@matux matux merged commit 9859866 into main Feb 26, 2024
4 checks passed
@matux matux deleted the matux/eslint-prettier-config branch February 26, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants