Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken package.json, updated all deps and react example #115

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 29, 2024

Vast majority of line changes come from package-lock.

Description of the change

This PR fixes some package.json discrepancies that were causing npm install to fail.

The main discrepancy was in the versions declared for react (16.x) and react-dom (17.x). Once this was fixed, a few other deps needed adjustment.

In the end, they were all updated to their latest React 17-supporting versions.

React version on peerDependencies remains untouched, ranging from 16 to 18.

The version of Typescript has also been bumped from 4 to 5. Although the source code is pure js.

eslint and prettier were also updated to their latest versions, these updates required that the rollup config js file be renamed to mjs due to its use of modules, and some minimal updates to the eslint config.

The .tools-versions file which declared node 14 has been removed, the project should be able to be npm installed and built using any LTS node beginning in 14, something the ci checks already since the recent changes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested review from waltjones and mudetroit February 29, 2024 13:14
@matux matux self-assigned this Feb 29, 2024
@matux matux force-pushed the matux/fix-package-json branch from 04aa540 to fd475bc Compare February 29, 2024 14:27
@matux matux force-pushed the matux/fix-package-json branch from 8f387c0 to 3c32082 Compare February 29, 2024 14:53
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small note here. If you want to push that work to another PR I am okay with that as well

Comment on lines +20 to +26
rules:
indent: [error, 2]
quotes:
- error
- single
- avoidEscape: true
allowTemplateLiterals: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference
9/10

Instead of putting formatting rules in eslint use prettier to check formatting. Use eslint-config-prettier. That way we don't end up in a situation where they conflict with one another.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me. This was like this when I moved it (I just reordered it so the overrides were left at the bottom).

I'll do it in a separate PR to keep things as tidy as possible!

@matux matux merged commit bae55a6 into main Feb 29, 2024
6 checks passed
@matux matux deleted the matux/fix-package-json branch February 29, 2024 15:36
@matux matux mentioned this pull request Feb 29, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants