Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated yalc to the project to link in-dev lib to examples #118

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Mar 1, 2024

Description of the change

This PR integrates yalc into the project to work with the SDK as a locally published package.

Due to this integration, examples that were using an older rollbar-react version, now use the local code. This in turn made examples/typescript fail due to breaking changes in the SDK. These were corrected.

  • A new script, scripts/install-all.js was added to take care of the entire project installation, library, examples + yalc publishing and adding the locally published lib to each example.

This script can be invoked via npm run install:all and it's used by the CI to install the project.

  • Another new script, script/clean.ts was created that cleans the entire project of the most common generated directories and files (eg. node_modules, .next, build, dist, etc.).

  • An issue when linting the next.js example when running eslint from the root was also fixed. Linting from the root will ignore examples, run npm run lint:all to lint the library and the examples.

  • Another issue with linting only js files was fixed.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested review from waltjones and mudetroit March 1, 2024 20:35
@matux matux self-assigned this Mar 1, 2024
mudetroit
mudetroit previously approved these changes Mar 1, 2024
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed separately not sure if we will need yalc long term but in terms of keeping our current examples in line it makes sense to me

@matux matux requested a review from mudetroit March 4, 2024 13:11
@matux matux changed the title Integrated yalc to the project to use with examples Integrated yalc to the project to link in-dev lib to examples Mar 4, 2024
@matux matux merged commit 997735a into main Mar 5, 2024
7 checks passed
@matux matux deleted the matux/yalc branch March 5, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants