Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup nextjs examples #128

Merged
merged 12 commits into from
Oct 24, 2024
Merged

Cleanup nextjs examples #128

merged 12 commits into from
Oct 24, 2024

Conversation

mudetroit
Copy link
Contributor

@mudetroit mudetroit commented Oct 23, 2024 •
edited
Loading

Description of the change

Updates to the nextjs example projects to match documentation updates to be released soon

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Linear stories and GitHub issues

  • Fix SDK-16

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@mudetroit mudetroit self-assigned this Oct 23, 2024
@linear Linear
Copy link

linear bot commented Oct 23, 2024

SDK-16 Update NextJS documentation

matux
matux requested changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, most important a discrepancy between the docs and the example code.

examples/nextjs-approuter/src/app/fonts/GeistMonoVF.woff Outdated Show resolved Hide resolved
examples/nextjs-approuter/src/app/rollbar_error_boundary/page.tsx Show resolved Hide resolved
examples/nextjs-approuter/src/components/ResetPage.tsx Outdated Show resolved Hide resolved
examples/nextjs-approuter/src/rollbar.ts Show resolved Hide resolved
examples/nextjs/.gitignore Show resolved Hide resolved
examples/nextjs/src/pages/fonts/GeistMonoVF.woff Outdated Show resolved Hide resolved
examples/nextjs/tsconfig.json Show resolved Hide resolved
@mudetroit mudetroit force-pushed the matt/cleanup-nextjs-examples branch 3 times, most recently from 78f29ee to 367bb49 Compare October 23, 2024 18:43
@mudetroit mudetroit requested a review from matux October 23, 2024 18:52
@mudetroit
chore(ci): no more node v16
e250a6b 
It has been EOL for more than a year now
matux
matux previously approved these changes Oct 23, 2024
View reviewed changes
@mudetroit mudetroit requested a review from matux October 24, 2024 00:23
@mudetroit mudetroit merged commit a9b7529 into main Oct 24, 2024
4 checks passed
@mudetroit mudetroit deleted the matt/cleanup-nextjs-examples branch October 24, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matux matux matux approved these changes

@waltjones waltjones Awaiting requested review from waltjones

Assignees

@mudetroit mudetroit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mudetroit @waltjones @matux