Allow rollbar instance from alternate import/require #37
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The Provider validates the Rollbar instance, when one is in the props, by testing
instanceof
the defaultRollbar
import. This fails when the instance was constructed from another import or require. The specific issue report involves using the noconflict bundle.This PR looks for an initialized options object instead. This will successfully catch common errors like passing the constructor function or failing to initialize before passing the instance.
Type of change
Related issues
Fixes #24
Development
Code review