Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorBoundary.fallbackUI can't be a node #46

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ijsnow
Copy link
Contributor

@ijsnow ijsnow commented Mar 11, 2022

Description of the change

The ErrorBoundary component's propTypes field says that it can be a react node or a function. However, if passed a node (e.g. <p>oops</p>), you get the following error:

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.

Check the render method of `ErrorBoundary`.

This PR simply removes the PropTypes.node reference from the definition.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Checklists

Development

  • Lint rules pass locally
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Changes have been reviewed by at least one other engineer

Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

This also helped me find and fix a couple other test/CI related issues.
#49
#50

@waltjones waltjones merged commit 19800db into rollbar:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants