Add children to the props for @types/react@18 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkas
approved these changes
May 19, 2022
|
@waltjones can Rollbar team merge this? needed to fix the TS errors |
|
Also waiting for that! 👍🏼 |
Andrew8xx8
approved these changes
May 24, 2022
dvislov
approved these changes
Jun 2, 2022
|
2 approves and still complaining of unable to merge until an approved approver approves... |
waltjones
approved these changes
Jun 3, 2022
|
Released in v0.11.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to React props should not do anything special with children and DefinitelyTyped have updated the react types to v18
DefinitelyTyped/DefinitelyTyped#59802