Make CMake package version ARCH_INDEPENDENT #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 326 326
=========================================
Hits 326 326 ☔ View full report in Codecov by Sentry. |
|
Of course. Much appreciated. Thank you! |
|
Thank you for the fast reply and such a great library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since strong_type is a header-only library, its package version should be considered compatible independent of the target architecture. The
ARCH_INDEPENDENToption ofwrite_basic_package_version_file()ensures just that. See the documentation for more details.Note that using
ARCH_INDEPENDENTincreases the minimum required CMake version to 3.14. Given how easy it is to get the latest CMake version on any platform, this should not be an issue, though (see the table under "Picking a CMake Version" of this blog post).