Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: outdated version notifier (spawn + local-ic) #156

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Jun 22, 2024

closes #155
ref: strangelove-ventures/interchaintest#1152

Summary

When a package is out of date (local-ic, spawn), we need to notify the users. This should only be run 1 time per day as it's a heavy operation.

image

Reason

When Matija was having spawn ICS issues, he was running local-ic v8.2.0, which did not have ICS support. So it was not apparent that a newer version was needed. This will resolve that issue both for spawn & local-ic. Same is useful for future spawn releases (could attach release notes into the binary itself too)

Ideal refactor

Ideally the makefile installer can automatically pull latest (i.e. make get-localic auto pulls v8.4.0, or v8.5.0, etc). Or this can be done within spawn? need to think on the UX here


TODO

  • Notify users packages are out of date
    • spawn
    • local-ic
  • Easily download latest
    • local-ic
    • spawn
  • Package the
    • changelog into the spawn bin? spawn changelog latest, show markdown in terminal
    • Package documentation into spawn bin? spawn docs kind of like man

@Reecepbcups
Copy link
Member Author

local-ic version added upstream. if you get-localic it sets the version right, but upstream only go install ./...'ed it. So if the version command is found, it's v8.5.0

Will fix this in v8.6.0

@Reecepbcups
Copy link
Member Author

@Reecepbcups
Copy link
Member Author

Upstreamed fix for ver notifier with local-ic: https://github.com/strangelove-ventures/interchaintest/releases/tag/v8.6.0

@Reecepbcups Reecepbcups changed the title feat: outdated version notifier feat: outdated version notifier (spawn + local-ic) Jul 22, 2024
@Reecepbcups Reecepbcups marked this pull request as ready for review July 22, 2024 15:47
@Reecepbcups Reecepbcups merged commit e8c1755 into release/v0.50 Jul 22, 2024
9 checks passed
@Reecepbcups Reecepbcups deleted the reece/local-ic-notifier branch August 30, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make: prompt / notify updating local-ic
1 participant