Use snapshots for undo #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests verify the behaviour of the game state as displayed on the main scoreboard (except Jammer names). Not included: - Undo. This will be added together with the switch to a snapshot model in a separate PR. - Game Statistics (Penalties, Lineups) - Settings other than WFTDA sanctioned (with a few exceptions).
Whenever one of the clock control buttons is pressed (Start Jam, Stop Jam/TO, Timeout), a snapshot of the scoreboard state is taken. On undo the last snapshot is restored and the running clocks are advanced by the time that has passed since the snapshot was taken. Un-Start, Un-Stop and Un-Timeout are wrappers for the general undo function that check if the current snapshot is of the approriate type and do nothing if it isn't. This prepares the backend for a single undo button but doesn't add it to the frontend. The latter is planned as an option, after we have a better way of handling operator settings than a long row of buttons.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever one of the clock control buttons is pressed (Start Jam, Stop
Jam/TO, Timeout), a snapshot of the scoreboard state is taken. On undo
the last snapshot is restored and the running clocks are advanced by the
time that has passed since the snapshot was taken.
Un-Start, Un-Stop and Un-Timeout are wrappers for the general undo
function that check if the current snapshot is of the approriate type
and do nothing if it isn't.
This prepares the backend for a single undo button but doesn't add it to
the front end. The latter is planned as an option, after we have a
better way of handling operator settings than a long row of buttons.