Tcrd foreground fix #136
Tcrd foreground fix #136
Conversation
| if (match == null || match.length == 0) | ||
| return; | ||
| var id = match[1]; // id = skater id | ||
| var prefix = 'ScoreBoard.Team(' + t + ').Skater(' + id + ')'; //Example: prefix = ScoreBoard.Team('1').Skater('id') | ||
| if (k == prefix + '.Number') { //Example if skater id == ScoreBoard.Team('team').Skater('id').Number |
There was a problem hiding this comment.
This doesn't hurt to keep
There was a problem hiding this comment.
It's wrong, though. I pulled all my old comments because they were largely incorrect. I'll put in a more coherent comment instead.
html/views/wb/tcdg2016wb.js
Outdated
| var fo_exp = ($($('.Team' + t + ' .Skater.Penalty[id=' + s + '] .BoxFO_EXP')[0]).data("id") != null); | ||
| // Change row colors for skaters on 5 or more penalties, or who have been expelled. | ||
| var cnt = 0; | ||
| var fo_exp = ($($('.Team' + t + ' .Skater.Penalty[id=' + s + '] .BoxFO_EXP')[0]).data("id") != null); |
There was a problem hiding this comment.
indentation is off here
There was a problem hiding this comment.
It's not showing up this way in Eclipse, so I'm a little puzzled.
| pd.append($('<div>').addClass('BoxFO_EXP').html(' ')); | ||
| pd.append($('<div>').addClass('Total').text('0')); | ||
| pd.append($('<div>').addClass('BoxFO_EXP').html(' ').css('color',teamFColor)); | ||
| pd.append($('<div>').addClass('Total').text('0').css('color',teamFColor)); |
There was a problem hiding this comment.
Is this the best way to handle this?
The existing colour handling code is up around line 38, and we should try to keep with that.
There was a problem hiding this comment.
The existing color handling code at line 38 just assigns the colors to a custom class. Attempting to assign the custom class to the partial row where the penalty data lives breaks the appearance pretty badly. I'm open to other suggestions, but I've not been able to figure out another way to do this that doesn't look terrible
There was a problem hiding this comment.
Could you use your approach from https://github.com/rollerderby/scoreboard/blob/dev/html/views/standard/index.js#L87 ?
There was a problem hiding this comment.
That's kind of overkill. The reason it's done that way in the SB is because it has to deal with the :before and :after pseudoclasses which can't be directly modified from the JS. If I could have used the approach I've proposed here for the SB, I totally would have.
There was a problem hiding this comment.
Looking through the other dashboards, we appear to have a mix of techniques for this.
We should probably look at adding a utility function to manage the css classes for this, the XML side of the house has something vaguely in that area.
Updates the TCRD overlay and whiteboard screens so that the foreground text color uses the "overlay_fg" color.