Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caps lock #209

Merged
merged 1 commit into from
May 30, 2019
Merged

Caps lock #209

merged 1 commit into from
May 30, 2019

Conversation

brian-brazil
Copy link
Contributor

No description provided.

@brian-brazil
Copy link
Contributor Author

This updates state any time a key is pressed (including capslock). That's the most that seems possible with JS.

@frank-weinberg
Copy link
Contributor

When pressing Caps Lock itself the display status is set the wrong way. On all other key presses (including Shift or Control) it works as expected.

@brian-brazil
Copy link
Contributor Author

It's working correctly for me. What OS/Browser are you on?

@frank-weinberg
Copy link
Contributor

This was with Firefox and IE on Win7. Can try with Firefox and Chrome under Linux later today.

@frank-weinberg
Copy link
Contributor

On Linux it works as expected in both browsers. So it's a Windows problem. (And I won't be at my Windows computer for the next two weeks.)

@brian-brazil
Copy link
Contributor Author

Okay, presumably Windows changes when the Caps Lock is activated at a different point in the key press than Linux.

@brian-brazil
Copy link
Contributor Author

I've tweaked this so it should work better across OSes.

@frank-weinberg
Copy link
Contributor

This appears to work correctly now on all combinations of Win7 or Linux with Firefox or Chrome.

@frank-weinberg frank-weinberg merged commit dcaf5aa into dev May 30, 2019
@brian-brazil brian-brazil deleted the caps-lock branch May 30, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants