Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old scoreboard. #229

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Remove old scoreboard. #229

merged 2 commits into from
Apr 13, 2019

Conversation

brian-brazil
Copy link
Contributor

The WS scoreboard is now feature-equivilent.

Remove minimal animations option, it does
nothing for WS.

The WS scoreboard is now feature-equivilent.

Remove minimal animations option, it does
nothing for WS.
@frank-weinberg
Copy link
Contributor

I object to removing side padding:

  1. I have seen problems where browser or OS have cut off the edges. No projector will fix that.
  2. Even when it can be fixed in the projector you need to have someone at hand who knows how or has time to figure it out. This is not a given for a significant portion of derby events.

I also do not see the point of removing other box style options. Not every venue uses a projector to display the scoreboard. So other options may be of use to only a small percentage of users but keeping them is essentially no effort.

Third, those two commits probably should not be a single PR.

@brian-brazil
Copy link
Contributor Author

I have seen problems where browser or OS have cut off the edges. No projector will fix that.

If it's a aspect ratio issue (which seems most likely), 10% isn't enough to fix it. At that stage you can either resize the browser or fix the display settings.

Not every venue uses a projector to display the scoreboard. So other options may be of use to only a small percentage of users but keeping them is essentially no effort.

It's still something to maintain, and the output should be as bright as possible in any case.

Third, those two commits probably should not be a single PR.

I was being lazy.

@frank-weinberg
Copy link
Contributor

I have seen problems where browser or OS have cut off the edges. No projector will fix that.

If it's a aspect ratio issue (which seems most likely), 10% isn't enough to fix it. At that stage you can either resize the browser or fix the display settings.

Resizing the Browser is not an option in full screen. And fixing the display settings can be difficult if you don't know which exact setting is the culprit, the OS is in a foreign language and/or you don't have the admin password.
I've personally had at least a dozen instances in the last few years where using this option came in handy.

Not every venue uses a projector to display the scoreboard. So other options may be of use to only a small percentage of users but keeping them is essentially no effort.

It's still something to maintain, and the output should be as bright as possible in any case.

We've already spent more effort on this discussion than maintaining this option took in the last 5+ years.

The brighter the better for projectors.
Flat&bright shouldn't have a gradient on the OR/TO/OTO box.

Fix handling of removal of scoreboard_dots.
@brian-brazil brian-brazil force-pushed the remove-old-scoreboard branch from b957bec to 0539967 Compare April 13, 2019 13:24
@brian-brazil
Copy link
Contributor Author

Updated.

@frank-weinberg frank-weinberg merged commit e0c2082 into dev Apr 13, 2019
@brian-brazil brian-brazil deleted the remove-old-scoreboard branch April 13, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants