Select team after creating it. #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a common confusion. This is hacky, but we can improve once this is on WS.
| @@ -1435,6 +1435,8 @@ function createTeamsContent() { | |||
| var teamid = _crgUtils.checkSbId(teamname); | |||
| $sb("Teams.Team("+teamid+").Name").$sbSet(teamname); | |||
| newTeamName.val("").keyup().focus(); | |||
| // Presume we'll have gotten the XML update within 100ms. | |||
| setTimeout(function(){selectTeam.val(teamname);}, 100); | |||
There was a problem hiding this comment.
How certain are you that 100ms is sufficient, especially when the operator screen is not on the same machine as the backend?
There was a problem hiding this comment.
It'll all be in the same sports hall, and thus within 1-2ms. I'd be more worried about the backend being slow.
There was a problem hiding this comment.
This only selects the team in the dropdown but doesn't change the bottom part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common confusion. This is hacky, but we can
improve once this is on WS.