Be more efficient in how we look up watched WS paths. #260

brian-brazil · 2019-05-10T21:19:33Z

1.5s -> 60ms.

brian-brazil · 2019-05-11T11:55:00Z

Hold up, might be a bug here.

Processing many hundreds of XML elements that we don't need takes hundreds of milliseconds.

This makes it easier to write handlers.

brian-brazil · 2019-05-11T15:07:07Z

Okay, expanded the scope a bit. We're now going from ~20s to ~1.5s overall.

This brings us from ~20s to ~1.5s with 60ish Jams, and is also generally more responsive. Time the WS.Connect after all the registrations, to avoid n^2 updates in the browser. Use one big optimised handler over many tiny leaking handlers. Cache element lookups.

For long lived screens with lots of churn, this could be an issue.

brian-brazil · 2019-05-12T21:55:42Z

And PT loading with 90 penalties is now 5x faster. Creating penalties is already quite fast, so no need for changes there.

Overall effect is to make the JS ~5x faster to load the PT screen. Don't adjust more than we have to on each update. Be smarter on updating team penalty total. Be smarter about how we search the DOM.

frank-weinberg

The period and jam tables in the operator screen could probably also profit from a rework using the amended WS keys.

frank-weinberg · 2019-05-14T15:12:14Z

src/com/carolinarollergirls/scoreboard/jetty/WS.java

+                return;
+              }
+              if (i >= p.length()) {
+                break;


This condition should be in the head of the loop.

That'd result in us iterating once when we don't need to, which is why the head.exists check is before it.

frank-weinberg · 2019-05-14T15:14:52Z

src/com/carolinarollergirls/scoreboard/jetty/WS.java

+            PathTrie head = this;
+            for (int i = 0;; i++) {
+              if (head.exists) {
+                // Already covered.


This comment doesn't really make sense in this function.

frank-weinberg · 2019-05-14T15:23:27Z

html/controls/sk/sk-sheet.js

+				break;
+
+			 default:
+				if (k.parts[4] == 'ScoringTrip' && k.ScoringTrip >= 3 && k.ScoringTrip <= 10) {


This should be <10.
Trip 10 is already part of the cell that's treated below.

frank-weinberg · 2019-05-14T15:27:54Z

html/controls/sk/sk-sheet.js

-							scoreAfterSP = scoreAfterSP=='' ? tripScore : scoreAfterSP + "+" + tripScore;
-						} else {
-							scoreBeforeSP = scoreBeforeSP=='' ? tripScore : scoreBeforeSP + "+" + tripScore;
+				} else if (k.parts[4] == 'ScoringTrip' && k.ScoringTrip > 10) {


frank-weinberg · 2019-05-14T15:29:43Z

html/controls/sk/sk-sheet.js

+							if (isTrue(WS.state[prefix+'ScoringTrip('+t+').AfterSP'])) {
+								scoreAfterSP = scoreAfterSP=='' ? tripScore : scoreAfterSP + "+" + tripScore;
+							} else {
+								scoreBeforeSP = scoreBeforeSP=='' ? tripScore : scoreBeforeSP + "+" + tripScore;


These need spaces around the + so the text will wrap when needed

Done, though the wrapping means the SK tables no longer align in the (rare) case someone somehow manages to have 11+ scoring passes.

frank-weinberg · 2019-05-14T15:30:04Z

html/controls/sk/sk-sheet.js

-				spRow.find('Trip10').text(scoreAfterSP);
+					});
+					jamRow.find('Trip10').text(scoreBeforeSP);
+					spRow.find('Trip10').text(scoreAfterSP);


These need to be .Trip10

frank-weinberg · 2019-05-14T15:31:51Z

html/controls/sk/sk-sheet.js

+				} else if (k.parts[4] == 'ScoringTrip' && k.ScoringTrip > 10) {
+					var scoreBeforeSP = '';
+					var scoreAfterSP = '';
+					$.each(new Array(3), function(idx) {


Since you're now catching any trip index, this should be a while loop that ends, when a trip score is null.

frank-weinberg · 2019-05-14T15:36:46Z

html/controls/sk/sk-sheet.js

 		}
 	}
-
-	function finalizePeriod(nr) {} //TODO: implement


Why did you remove this? This is still an active todo on my list.

It's dead code currently, it can be added back when needed.

frank-weinberg · 2019-05-14T15:56:09Z

html/controls/plt/plt-input.js

@@ -29,7 +29,11 @@ function preparePltInputTable(element, teamId, mode, statsbookPeriod, alternateN
 			$('<td>').text('Pivot').appendTo(thead);
 			$('<td>').text('Blocker').appendTo(thead);
 			$('<td>').text('Box').appendTo(thead);
-			$('<td>').appendTo(thead);
+			if (mode == 'lt') {
+				$('<td>').attr('id', 'head').text('Team ' + teamId).appendTo(thead);


This field is to small for a long team name.
I'd rather use it for the SP indicator (on PLT as well).

You're probably right, but it'll do the job for now.

brian-brazil · 2019-05-14T16:17:02Z

The period and jam tables in the operator screen could probably also profit from a rework using the amended WS keys.

They're actually a notable hotspot (though this PR helps), so I'll be reworking them at some point.

brian-brazil added 3 commits May 11, 2019 16:02

Skip processing stats in XML frontend

0b2ad2c

Processing many hundreds of XML elements that we don't need takes hundreds of milliseconds.

Be more efficient in how we look up watched WS paths.

a644902

Parse property name in WS code.

56db049

This makes it easier to write handlers.

brian-brazil force-pushed the ws-perf branch from ce53fbc to a84aae6 Compare May 11, 2019 15:05

brian-brazil mentioned this pull request May 11, 2019

Skip processing stats in XML frontend #231

Closed

brian-brazil force-pushed the ws-perf branch from a84aae6 to 0e48a0a Compare May 11, 2019 15:20

brian-brazil added 2 commits May 12, 2019 00:23

Cleanup WS state and caches to avoid memory leak.

e0e68b1

For long lived screens with lots of churn, this could be an issue.

brian-brazil force-pushed the ws-perf branch from 0e48a0a to e0e68b1 Compare May 11, 2019 23:23

PT loading optimisations

773db51

Overall effect is to make the JS ~5x faster to load the PT screen. Don't adjust more than we have to on each update. Be smarter on updating team penalty total. Be smarter about how we search the DOM.

brian-brazil force-pushed the ws-perf branch from a05e219 to 773db51 Compare May 13, 2019 11:31

On LT screen, put team name in currently unused td.

a6ae464

frank-weinberg reviewed May 14, 2019

View reviewed changes

Address code review comments.

f53ba7c

frank-weinberg merged commit 76bc323 into dev May 14, 2019

brian-brazil deleted the ws-perf branch May 14, 2019 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Be more efficient in how we look up watched WS paths. #260

Be more efficient in how we look up watched WS paths. #260

brian-brazil commented May 10, 2019

brian-brazil commented May 11, 2019

brian-brazil commented May 11, 2019

brian-brazil commented May 12, 2019

frank-weinberg left a comment

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

frank-weinberg May 14, 2019

brian-brazil May 14, 2019

brian-brazil commented May 14, 2019

Be more efficient in how we look up watched WS paths. #260

Be more efficient in how we look up watched WS paths. #260

Conversation

brian-brazil commented May 10, 2019

brian-brazil commented May 11, 2019

brian-brazil commented May 11, 2019

brian-brazil commented May 12, 2019

frank-weinberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brian-brazil commented May 14, 2019