Consider all running clocks when doing clock sync. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // with respect to the running clocks. | ||
| ClockImpl masterClock = clocks.get(0); | ||
| long nowMs = masterClock.getTime() % 1000; |
There was a problem hiding this comment.
This is hiding a class variable.
There was a problem hiding this comment.
Ah, forgot to remove that.
Let me dig into that test. Things were test-order dependent previously, but this change should have fixed that in passing....
There was a problem hiding this comment.
I've run all the tests for ~2.5 hours, with no failures.
This is simpler, and avoids going out of sync. Fix precision issue in isDisplayChange. Fixes #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simpler, and avoids going out of sync.
Fix precision issue in isDisplayChange.
Fixes #191