Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for scoreboard state: clocks and scores #88

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

brian-brazil
Copy link
Contributor

These allow tying performance metrics back to jam
times/numbers as people are more likely to know those
than NTP-synced unixtime that a monitoring system
like Prometheus usually deals with.

These allow tying performance metrics back to jam
times/numbers as people are more likely to know those
than NTP-synced unixtime that a monitoring system
like Prometheus usually deals with.
@riffreff
Copy link
Contributor

riffreff commented Jul 2, 2018

It is not that simple. If the teams have a different number of skaters you end up with different row heights for the two teams.
capture

@official-sounding
Copy link
Contributor

@riffreff I think you meant your comment for #86, not here

@brian-brazil
Copy link
Contributor Author

#84 I think you meant.

@official-sounding
Copy link
Contributor

(you're right, #84 is the correct issue for the row re-sizing)

This change looks good to me. I'm assuming prometheus doesn't impose much of a resource penalty for it's metrics collection? is it worth considering putting the metrics collection behind a command line argument (or perhaps allowing turning off metrics collection with a command line flag?)

@brian-brazil
Copy link
Contributor Author

If you don't hit the endpoint, this code will never be called. Even then it's quite cheap.

What does cost is the direct instrumentation elsewhere, but that's measured in nanoseconds. There's enough expensive endpoints already that I don't see a point in disabling just this one, particularly as it would make performance analysis quite a bit harder.

@brian-brazil brian-brazil merged commit 7f9a247 into dev Jul 3, 2018
@brian-brazil brian-brazil deleted the sbm-metrics branch July 3, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants