Eliminate compiler & lint warnings #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supress warning for comparing identical expressins in example test
Exception: serial version UIDs remain excluded Currently this gives no warnings on a clean build
brian-brazil
reviewed
Jul 6, 2018
| @@ -10,6 +11,7 @@ | |||
| public class ExampleTest { | |||
|
|
|||
| @Test | |||
| @SuppressWarnings("all") | |||
There was a problem hiding this comment.
Let's just delete this test.
|
I don't have a preference for merge order. I expect having to do a manual merge either way. |
|
It's probably safest to do this one 2nd, as it's largely mechanical. |
|
Given that you requested more work put into the other PR, I'd rather see this one merged before more conflicting PRs are added. |
|
Sure. |
brian-brazil
added a commit
that referenced
this pull request
Aug 18, 2018
PR #97 had a regression that started setting an ID when reading in penalties from the autosave, causing them to get silently disgarded.
brian-brazil
added a commit
that referenced
this pull request
Aug 18, 2018
PR #97 had a regression that started setting an ID when reading in penalties from the autosave, causing them to get silently disgarded.
brian-brazil
added a commit
to brian-brazil/scoreboard
that referenced
this pull request
Aug 18, 2018
…by#137) PR rollerderby#97 had a regression that started setting an ID when reading in penalties from the autosave, causing them to get silently disgarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit comments for details. I kept it to one type of warning per commit for easier review.