Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: shared folder refactor #345

Closed
12 of 13 tasks
NikitaStarmoussov opened this issue Jun 26, 2024 · 0 comments
Closed
12 of 13 tasks

FSD: shared folder refactor #345

NikitaStarmoussov opened this issue Jun 26, 2024 · 0 comments

Comments

@NikitaStarmoussov
Copy link
Collaborator

NikitaStarmoussov commented Jun 26, 2024

📝 Describe the refactoring task

Shared folder refactor

📍 Code location

"@/shared/"

🛠️ Suggested improvement

"Example" PR
Презентация по FSD

✅ Definition of Done (DoD):

Everything on the list has been refactored

TO-DO

  1. UI:

2) Data (related: - Data will be refactored separately as it's own milestone

3) Assets + icons - Assets decided to leave as it is, icons can be refactored separately but not yet necessary

4) hooks: use-course-by-title, use-data-by-name, app/services/api - Part of the huge milestone for data refactor (data will be fetched from external CDN so this hooks will be deleted)

update 26.08.24:

  1. Icons from now on are imported directly into components where needed using the image component, no need to create icons wrapper e.g. icons folder
  2. "3. Assets + icons" and "4. hooks: use-course-by-title, use-data-by-name, app/services/api"- decided to exclude from FSD refactor and expected to perform as a separate issues after we fully complete the migration
@NikitaStarmoussov NikitaStarmoussov moved this to Backlog in RS Site Jun 26, 2024
@NikitaStarmoussov NikitaStarmoussov changed the title Shared folder refactor FSD: shared folder refactor Jun 26, 2024
@natanchik natanchik moved this from Backlog to Todo in RS Site Jul 1, 2024
@ismoilkhon ismoilkhon self-assigned this Jul 1, 2024
@ismoilkhon ismoilkhon moved this from Todo to In Progress in RS Site Jul 1, 2024
@ismoilkhon ismoilkhon moved this from In Progress to Todo in RS Site Jul 1, 2024
@ismoilkhon ismoilkhon moved this from Todo to In Progress in RS Site Jul 2, 2024
@ismoilkhon ismoilkhon changed the title FSD: shared folder refactor FSD: paragraph refactor Jul 2, 2024
@ismoilkhon ismoilkhon changed the title FSD: paragraph refactor FSD: shared folder refactor Jul 2, 2024
@ismoilkhon ismoilkhon linked a pull request Jul 2, 2024 that will close this issue
8 tasks
@ansivgit ansivgit moved this from In Progress to Todo in RS Site Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment