Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

348-refactor: Title component refactor #350

Merged
merged 71 commits into from
Jul 4, 2024

Conversation

NikitaStarmoussov
Copy link
Collaborator

@NikitaStarmoussov NikitaStarmoussov commented Jun 26, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Example of component refactoring for shared

Related Tickets & Documents

Screenshots, Recordings

Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2024-06-26 Π² 20 59 18

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

  • New Features

    • Introduced MainTitle and WidgetTitle components with enhanced customization options for better consistency and flexibility in title rendering.
  • Enhancements

    • Updated styles for main and widget titles, including new font size variables and responsive design improvements.
    • Improved margin and alignment styles for headers (h1, h2) and figures to ensure consistent presentation across the application.
  • Bug Fixes

    • Addressed margin issues for h1 elements within sections and articles to enhance cross-browser compatibility.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7e04bc6 and 266530d.

Files selected for processing (1)
  • eslint.config.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • eslint.config.js

Copy link

github-actions bot commented Jul 2, 2024

Lighthouse Report:

  • Performance: 94 / 100
  • Accessibility: 88 / 100
  • Best Practices: 93 / 100
  • SEO: 91 / 100

View detailed report

Copy link

github-actions bot commented Jul 4, 2024

Qodana for JS

It seems all right πŸ‘Œ

No new problems were found according to the checks applied

πŸ’‘ Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 82 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
@next/env 14.2.3 MIT
@next/swc-linux-x64-gnu 14.2.3 MIT
@next/swc-linux-x64-musl 14.2.3 MIT
@playwright/test 1.45.0 Apache-2.0
@remix-run/router 1.17.0 MIT
@swc/counter 0.1.3 Apache-2.0
@swc/helpers 0.5.5 Apache-2.0
anymatch 3.1.3 ISC
binary-extensions 2.3.0 MIT
braces 3.0.3 MIT
brcast 3.0.2 MIT
busboy 1.6.0 MIT
caniuse-lite 1.0.30001616 CC-BY-4.0
chokidar 3.6.0 MIT
class-variance-authority 0.7.0 Apache-2.0
classnames 2.5.1 MIT
client-only 0.0.1 MIT
clsx 2.0.0 MIT
css-vendor 0.3.8 MIT
dayjs 1.11.11 MIT
fill-range 7.1.1 MIT
glob-parent 5.1.2 ISC
graceful-fs 4.2.11 ISC
hoist-non-react-statics 2.5.5 BSD-3-Clause
hyphenate-style-name 1.0.4 BSD-3-Clause
immutable 4.3.5 MIT
is-binary-path 2.1.0 MIT
is-function 1.0.2 MIT
is-glob 4.0.3 MIT
is-in-browser 1.1.3 MIT
is-number 7.0.0 MIT
is-plain-object 2.0.4 MIT
isobject 3.0.1 MIT
js-tokens 4.0.0 MIT
jss-camel-case 6.1.0 MIT
jss-compose 5.0.0 MIT
jss-default-unit 8.0.2 MIT
jss-expand 5.3.0 MIT
jss-extend 6.2.0 MIT
jss-global 3.0.0 MIT
jss-nested 6.0.1 MIT
jss-preset-default 4.5.0 MIT
jss-props-sort 6.0.0 MIT
jss-template 1.0.1 MIT
jss-vendor-prefixer 7.0.0 MIT
jss 9.8.7 MIT
loose-envify 1.4.0 MIT
nanoid 3.3.7 MIT
next 14.2.3 MIT
nextjs-toploader 1.6.12 MIT
normalize-path 3.0.0 MIT
nprogress 0.2.0 MIT
object-assign 4.1.1 MIT
picocolors 1.0.1 ISC
picomatch 2.3.1 MIT
playwright-core 1.45.0 Apache-2.0
playwright 1.45.0 Apache-2.0
postcss 8.4.31 MIT
prop-types 15.8.1 MIT
react-dom 16.14.0 MIT
react-dom 18.3.1 MIT
react-double-marquee 1.1.0 MIT
react-easy-swipe 0.0.21 MIT
react-is 16.13.1 MIT
react-json-pretty 2.2.0 MIT
react-jss 8.6.1 MIT
react-responsive-carousel 3.2.23 MIT
react-router-dom 6.24.0 MIT
react-router 6.24.0 MIT
react 16.14.0 MIT
react 18.3.1 MIT
readdirp 3.6.0 MIT
sass 1.77.6 Apache-2.0
scheduler 0.19.1 MIT
scheduler 0.23.2 MIT
source-map-js 1.2.0 BSD-3-Clause
streamsearch 1.1.0 MIT
styled-jsx 5.1.1 MIT
theming 1.3.0 MIT
to-regex-range 5.0.1 MIT
tslib 2.6.2 0BSD
warning 3.0.0 BSD-3-Clause
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 266530d and b40d9be.

Files selected for processing (3)
  • eslint.config.js (1 hunks)
  • src/app/styles/index.scss (1 hunks)
  • src/app/styles/normalize.scss (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/app/styles/normalize.scss
Files skipped from review as they are similar to previous changes (2)
  • eslint.config.js
  • src/app/styles/index.scss

Copy link

github-actions bot commented Jul 4, 2024

Lighthouse Report:

  • Performance: 76 / 100
  • Accessibility: 88 / 100
  • Best Practices: 93 / 100
  • SEO: 91 / 100

View detailed report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSD: title refactor
7 participants