Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

268-feat: Rework mobile menu #454

Merged
merged 6 commits into from
Aug 24, 2024
Merged

268-feat: Rework mobile menu #454

merged 6 commits into from
Aug 24, 2024

Conversation

Wystov
Copy link
Collaborator

@Wystov Wystov commented Aug 20, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ§‘β€πŸ’» Code Refactor

Description

  • Changed mobile menu to have same structure as desktop.
  • styles to module.scss

Related Tickets & Documents

Screenshots, Recordings

header

Added/updated tests?

  • πŸ‘Œ Yes

[optional] What gif best describes this PR or how it makes you feel?

cat

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a new responsive mobile view component with enhanced styling and navigation.
    • Added classes to define and improve visual layout and usability for mobile elements.
  • Bug Fixes

    • Streamlined test cases for the Footer component to focus on essential rendering functionalities.
  • Style

    • Updated styling approach in the MobileView component to utilize CSS modules for better encapsulation.
    • Improved overall styling consistency across mobile view elements.

Copy link
Contributor

coderabbitai bot commented Aug 20, 2024

Walkthrough

Walkthrough

The update enhances the mobile menu's functionality and styling to align with desktop navigation. Key modifications include refining test cases for the Footer component, creating a new SCSS file for mobile view styles, and updating the MobileView component to utilize CSS modules for improved style encapsulation and navigation clarity.

Changes

Files Change Summary
src/app/layouts/base-layout/components/footer/footer.test.tsx, src/widgets/mobile-view/ui/mobile-view.module.scss, src/widgets/mobile-view/ui/mobile-view.tsx Simplified test cases for Footer, added mobile view styles with a flexbox layout, and updated MobileView component for CSS module usage and improved navigation.

Assessment against linked issues

Objective Addressed Explanation
Improve UX for mobile menu (#268) βœ…
Harmonize mobile menu with desktop nav (#268) βœ…

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 25b3d92 and 4e33a6d.

Files selected for processing (1)
  • src/widgets/mobile-view/ui/mobile-view.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/widgets/mobile-view/ui/mobile-view.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 20, 2024

Qodana for JS

It seems all right πŸ‘Œ

No new problems were found according to the checks applied

πŸ’‘ Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 82 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
@next/env 14.2.4 MIT
@next/swc-linux-x64-gnu 14.2.4 MIT
@next/swc-linux-x64-musl 14.2.4 MIT
@playwright/test 1.45.3 Apache-2.0
@remix-run/router 1.19.0 MIT
@swc/counter 0.1.3 Apache-2.0
@swc/helpers 0.5.5 Apache-2.0
anymatch 3.1.3 ISC
binary-extensions 2.3.0 MIT
braces 3.0.3 MIT
brcast 3.0.2 MIT
busboy 1.6.0 MIT
caniuse-lite 1.0.30001640 CC-BY-4.0
chokidar 3.6.0 MIT
class-variance-authority 0.7.0 Apache-2.0
classnames 2.5.1 MIT
client-only 0.0.1 MIT
clsx 2.0.0 MIT
css-vendor 0.3.8 MIT
dayjs 1.11.12 MIT
fill-range 7.1.1 MIT
glob-parent 5.1.2 ISC
graceful-fs 4.2.11 ISC
hoist-non-react-statics 2.5.5 BSD-3-Clause
hyphenate-style-name 1.1.0 BSD-3-Clause
immutable 4.3.6 MIT
is-binary-path 2.1.0 MIT
is-function 1.0.2 MIT
is-glob 4.0.3 MIT
is-in-browser 1.1.3 MIT
is-number 7.0.0 MIT
is-plain-object 2.0.4 MIT
isobject 3.0.1 MIT
js-tokens 4.0.0 MIT
jss-camel-case 6.1.0 MIT
jss-compose 5.0.0 MIT
jss-default-unit 8.0.2 MIT
jss-expand 5.3.0 MIT
jss-extend 6.2.0 MIT
jss-global 3.0.0 MIT
jss-nested 6.0.1 MIT
jss-preset-default 4.5.0 MIT
jss-props-sort 6.0.0 MIT
jss-template 1.0.1 MIT
jss-vendor-prefixer 7.0.0 MIT
jss 9.8.7 MIT
loose-envify 1.4.0 MIT
nanoid 3.3.7 MIT
next 14.2.4 MIT
nextjs-toploader 1.6.12 MIT
normalize-path 3.0.0 MIT
nprogress 0.2.0 MIT
object-assign 4.1.1 MIT
picocolors 1.0.1 ISC
picomatch 2.3.1 MIT
playwright-core 1.45.3 Apache-2.0
playwright 1.45.3 Apache-2.0
postcss 8.4.31 MIT
prop-types 15.8.1 MIT
react-dom 16.14.0 MIT
react-dom 18.3.1 MIT
react-double-marquee 1.1.0 MIT
react-easy-swipe 0.0.21 MIT
react-is 16.13.1 MIT
react-json-pretty 2.2.0 MIT
react-jss 8.6.1 MIT
react-responsive-carousel 3.2.23 MIT
react-router-dom 6.26.0 MIT
react-router 6.26.0 MIT
react 16.14.0 MIT
react 18.3.1 MIT
readdirp 3.6.0 MIT
sass 1.77.8 Apache-2.0
scheduler 0.19.1 MIT
scheduler 0.23.2 MIT
source-map-js 1.2.0 BSD-3-Clause
streamsearch 1.1.0 MIT
styled-jsx 5.1.1 MIT
theming 1.3.0 MIT
to-regex-range 5.0.1 MIT
tslib 2.6.3 0BSD
warning 3.0.0 BSD-3-Clause
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Wystov Wystov self-assigned this Aug 20, 2024
@Wystov Wystov marked this pull request as draft August 20, 2024 17:03
Copy link

Lighthouse Report:

  • Performance: 82 / 100
  • Accessibility: 94 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@rolling-scopes rolling-scopes deleted a comment from github-actions bot Aug 23, 2024
@Wystov Wystov marked this pull request as ready for review August 23, 2024 07:05
Copy link

Lighthouse Report:

  • Performance: 91 / 100
  • Accessibility: 94 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Wystov Wystov merged commit 48eaf11 into main Aug 24, 2024
4 checks passed
@Wystov Wystov deleted the feat/268-rework-mobile-menu branch August 24, 2024 08:46
@coderabbitai coderabbitai bot mentioned this pull request Dec 14, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework mobile menu
4 participants