Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

282-feat: Standardize links designation #467

Merged
merged 37 commits into from
Sep 13, 2024

Conversation

Wystov
Copy link
Collaborator

@Wystov Wystov commented Aug 29, 2024

What type of PR is this? (select all that apply)

  • 🍕 Feature

Description

Important

02.09.24 PO approved links design change in accordance to WCAG.

  • changed color and added underline of textVariant of CustomLink according to WCAG
  • reviewed all links on website and changed them to LinkCustom where applicable.
  • LinkCustom opens in new window now if 'external' prop passed to it. also if it's an textVariant of link, it will be marked with symbol indicating external link.
  • removed font size from textVariant of link, so it can inherit it from text where it's used.
  • changed about.data format to tsx, so we can use directly jsx from it and not just setInnerHtml from string as it worked before.
  • set default icons for variants, but they can be still replaced by manually passing icon prop to component
  • added 'custom' variant that has no default styling and relies on styles and classes passed as props

Related Tickets & Documents

Screenshots, Recordings

internal text link
image

external text link
image
image

Added/updated tests?

  • 👌 Yes

[optional] What gif best describes this PR or how it makes you feel?

IMG_8947

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a new blue color variable for consistent styling across the application.
    • Enhanced handling of external links with the new LinkCustom component, improving user experience and accessibility.
  • Bug Fixes

    • Simplified link rendering logic by removing unnecessary icon props, ensuring a cleaner user interface.
  • Chores

    • Streamlined imports and removed unused components to improve code maintainability.

@github-actions github-actions bot changed the title Feat/282 standardize links designation 282-feat: Standardize links designation Aug 29, 2024
@Wystov Wystov self-assigned this Aug 29, 2024
@ansivgit
Copy link
Collaborator

ansivgit commented Aug 30, 2024

There's not our styles for text links O-O

@Wystov
Copy link
Collaborator Author

Wystov commented Aug 30, 2024

There's not our styles for text links O-O

@ansivgit luckily i dont have any disabilities but i still barely can distinguish links from other text in "our styles". let alone the fact that they're completely failing WCAG criteria (i left a link in pr description, please check it out)

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 12, 2024

run visual now

9 similar comments
@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 12, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 12, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Sep 13, 2024

run visual now

Copy link

Lighthouse Report:

  • Performance: 76 / 100
  • Accessibility: 98 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

Copy link

Lighthouse Report:

  • Performance: 96 / 100
  • Accessibility: 98 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@SpaNb4 SpaNb4 merged commit 68b670b into main Sep 13, 2024
4 checks passed
@SpaNb4 SpaNb4 deleted the feat/282-standardize-links-designation branch September 13, 2024 10:40
@coderabbitai coderabbitai bot mentioned this pull request Sep 22, 2024
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Designation of Internal and External Links Site-Wide
6 participants