Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

535-refactor: Widget School Courses #572

Merged
merged 33 commits into from
Oct 10, 2024
Merged

535-refactor: Widget School Courses #572

merged 33 commits into from
Oct 10, 2024

Conversation

Quiddlee
Copy link
Member

@Quiddlee Quiddlee commented Sep 27, 2024 •
edited by coderabbitai bot
Loading

What type of PR is this? (select all that apply)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🚧 Breaking Change
  • 🧑‍💻 Code Refactor
  • 📝 Documentation Update

Description

School courses widget refactor

Related Tickets & Documents

Screenshots, Recordings

Screenshot 2024-09-27 at 23 32 53

Added/updated tests?

  • 👌 Yes
  • 🙅‍♂️ No, because they aren't needed
  • 🙋‍♂️ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

catjam

Summary by CodeRabbit

  • New Features

    • Introduced the CourseItem component to display course information.
    • Added CourseItemData type for enhanced data structure.
    • Replaced Courses component with UpcomingCourses in the Home page.
    • Added new constants for responsive design and course quantity limits.

  • Bug Fixes

    • Updated tests for the UpcomingCourses component to ensure correct rendering and behavior across different screen sizes.

  • Style

    • New SCSS styles for the upcoming courses module, enhancing layout and responsiveness.

  • Chores

    • Removed deprecated components and exports (e.g., CourseCard, RsBanner).
    • Updated constants for better management of course display limits.

@Quiddlee
refactor: 546 - rename CourseCard to course-item
6f68471
@Quiddlee
refactor: 546 - extract course-item styles to separate file
539f3e0
@Quiddlee
feat: 546 - add course-item unit tests
a3c1481
@Quiddlee
refactor: 546 - move course-item to entity course
672eff5
@Quiddlee
refactor: 546 - remove course-item styles from courses scss
f78ccc5
@Quiddlee
fix: 546 - courses imports
1ee229c
@Quiddlee
refactor: 546 - rename courses to courses-school
2e2b6de
@Quiddlee
refactor: 546 - rename courses scss to courses-school scss
872ac23
@Quiddlee
refactor: 546 - move tabletScreenBreakPoint to constants.ts
6d367e2
@Quiddlee
refactor: 546 - replace RsBanner with Image component
905878d
@Quiddlee
refactor: 546 - rename MAX_COURSE_COUNT to camelCase
50eb819
@Quiddlee
refactor: 546 - move courses-school test to ui folder
dcd2de5
@Quiddlee
refactor: 546 - move all the width and height to constants
249f5fa
@Quiddlee
refactor: 546 - remove all it.skip
430c8b5
@Quiddlee
refactor: 546 - get rid of divs
247abf4
@Quiddlee
refactor: 546 - move course item type to entity types
c229b9b
@Quiddlee
refactor: 546 - remove course icon alt attribute
7d6670c
@Quiddlee
refactor: 546 - add better class name
3e2d492
@Quiddlee
fix: 546 - remove blank line
2a9d275
@Quiddlee
refactor: 546 - replace date with time tag
710faa9
@Quiddlee
refactor: 546 - remove unnecessary test
3966ecb
@Quiddlee
refactor: 546 - change course entity re-exports
3d0f336
@Quiddlee
fix: 546 - course school import
4847b52
@Quiddlee
fix: 546 - correct test cases
0642967
@Quiddlee
refactor: 546 - change course language tag
d9bcd44
@github-actions github-actions bot changed the title Refactor/546 widget school courses 546-refactor: Widget school courses Sep 27, 2024
@Quiddlee Quiddlee changed the title 546-refactor: Widget school courses 546-refactor: Widget School Courses Sep 27, 2024
@Quiddlee Quiddlee changed the title 546-refactor: Widget School Courses 535-refactor: Widget School Courses Sep 27, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Lighthouse Report:

  • Performance: 100 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Quiddlee Quiddlee requested a review from ansivgit October 1, 2024 19:16
@Quiddlee Quiddlee merged commit 3539fb0 into main Oct 10, 2024
4 checks passed
@Quiddlee Quiddlee deleted the refactor/546-widget-school-courses branch October 10, 2024 13:13
This was referenced Oct 10, 2024
Merged
Merged
This was referenced Nov 14, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2024
Merged
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 14, 2024
Merged
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 3, 2025
Merged
8 tasks
This was referenced Feb 4, 2025
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ansivgit ansivgit ansivgit approved these changes

@SpaNb4 SpaNb4 SpaNb4 approved these changes

@andron13 andron13 Awaiting requested review from andron13 andron13 is a code owner

@dzmitry-varabei dzmitry-varabei Awaiting requested review from dzmitry-varabei dzmitry-varabei is a code owner

@natanchik natanchik Awaiting requested review from natanchik natanchik is a code owner

Assignees

@Quiddlee Quiddlee

Labels
preview refactor
Projects
None yet
Milestone
🛸 Migration to Feature Sliced Design ...
Development

Successfully merging this pull request may close these issues.

FSD: Widget School Courses
5 participants
@Quiddlee @ansivgit @SpaNb4 @apalchys @KristiBo