chore(repo): enable consistent-type-imports for typescript files (#…

…1325) * refactor: distinguish between types of import * add consistent-type-import into the eslint config * fix: change the import method of non compliant rules
rollup · Nov 27, 2022 · a2e582a · a2e582a
1 parent fd93b71
commit a2e582a
Show file tree

Hide file tree

Showing 72 changed files with 153 additions and 135 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -9,7 +9,8 @@ module.exports = {
     'sort-keys': 'off',
     'typescript-sort-keys/interface': 'off',
     'import/extensions': 'off',
-    'import/no-unresolved': 'off'
+    'import/no-unresolved': 'off',
+    '@typescript-eslint/consistent-type-imports': 'error'
   },
   overrides: [
     {

diff --git a/packages/alias/src/index.ts b/packages/alias/src/index.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 import type { ResolvedAlias, ResolverFunction, ResolverObject, RollupAliasOptions } from '../types';
 

diff --git a/packages/alias/types/index.d.ts b/packages/alias/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin, PluginHooks } from 'rollup';
+import type { Plugin, PluginHooks } from 'rollup';
 
 type MapToFunction<T> = T extends Function ? T : never;
 

diff --git a/packages/auto-install/src/index.ts b/packages/auto-install/src/index.ts
@@ -4,7 +4,7 @@ import mod from 'module';
 import { exec } from 'child_process';
 import { promisify } from 'util';
 
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 import type { RollupAutoInstallOptions } from '../types';
 

diff --git a/packages/auto-install/types/index.d.ts b/packages/auto-install/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 export interface RollupAutoInstallOptions {
   /**

diff --git a/packages/babel/test/types.ts b/packages/babel/test/types.ts
@@ -1,4 +1,5 @@
 /** eslint-disable @typescript-eslint/no-unused-vars */
+import type { RollupOptions } from 'rollup';
 
 import babelPlugin, {
   babel,
@@ -8,7 +9,7 @@ import babelPlugin, {
   createBabelOutputPluginFactory
 } from '../types';
 
-const rollupConfig: import('rollup').RollupOptions = {
+const rollupConfig: RollupOptions = {
   input: 'main.js',
   output: {
     file: 'bundle.js',

diff --git a/packages/babel/types/index.d.ts b/packages/babel/types/index.d.ts
@@ -1,6 +1,6 @@
-import { Plugin, PluginContext, TransformPluginContext } from 'rollup';
-import { FilterPattern, CreateFilter } from '@rollup/pluginutils';
-import * as babelCore from '@babel/core';
+import type { Plugin, PluginContext, TransformPluginContext } from 'rollup';
+import type { FilterPattern, CreateFilter } from '@rollup/pluginutils';
+import type * as babelCore from '@babel/core';
 
 export interface RollupBabelInputPluginOptions
   extends Omit<babelCore.TransformOptions, 'include' | 'exclude'> {

diff --git a/packages/beep/types/index.d.ts b/packages/beep/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 /**
  * 🍣 A Rollup plugin that beeps when a build ends with errors.

diff --git a/packages/buble/src/index.ts b/packages/buble/src/index.ts
@@ -1,5 +1,5 @@
 import { transform } from 'buble';
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 import { createFilter } from '@rollup/pluginutils';
 
 import type { RollupBubleOptions } from '../types';

diff --git a/packages/buble/test/types.ts b/packages/buble/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import buble from '..';
 

diff --git a/packages/buble/types/index.d.ts b/packages/buble/types/index.d.ts
@@ -1,6 +1,6 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { TransformOptions } from 'buble';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { TransformOptions } from 'buble';
+import type { Plugin } from 'rollup';
 
 export interface RollupBubleOptions extends TransformOptions {
   /**

diff --git a/packages/commonjs/types/index.d.ts b/packages/commonjs/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 type RequireReturnsDefaultOption = boolean | 'auto' | 'preferred' | 'namespace';
 type DefaultIsModuleExportsOption = boolean | 'auto';

diff --git a/packages/data-uri/src/index.ts b/packages/data-uri/src/index.ts
@@ -1,6 +1,6 @@
 import { URL } from 'url';
 
-import { Plugin, RollupError } from 'rollup';
+import type { Plugin, RollupError } from 'rollup';
 
 import { dataToEsm } from '@rollup/pluginutils';
 

diff --git a/packages/data-uri/types/index.d.ts b/packages/data-uri/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 /**
  * A Rollup plugin which imports modules from Data URIs.

diff --git a/packages/dsv/test/types.ts b/packages/dsv/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import dsv from '..';
 

diff --git a/packages/dsv/types/index.d.ts b/packages/dsv/types/index.d.ts
@@ -1,6 +1,6 @@
-import { DSVRowString } from 'd3-dsv';
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { DSVRowString } from 'd3-dsv';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 interface RollupDsvOptions {
   /**

diff --git a/packages/dynamic-import-vars/test/types.ts b/packages/dynamic-import-vars/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import dynamicImportVars, { dynamicImportToGlob } from '../src';
 

diff --git a/packages/dynamic-import-vars/types/index.d.ts b/packages/dynamic-import-vars/types/index.d.ts
@@ -1,5 +1,6 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
+import type { BaseNode } from 'estree';
 
 interface RollupDynamicImportVariablesOptions {
   /**
@@ -24,10 +25,7 @@ interface RollupDynamicImportVariablesOptions {
 
 export class VariableDynamicImportError extends Error {}
 
-export function dynamicImportToGlob(
-  node: import('estree').BaseNode,
-  sourceString: string
-): null | string;
+export function dynamicImportToGlob(node: BaseNode, sourceString: string): null | string;
 
 /**
  * Support variables in dynamic imports in Rollup.

diff --git a/packages/eslint/src/index.ts b/packages/eslint/src/index.ts
@@ -1,6 +1,6 @@
 import { relative, resolve, sep } from 'path';
 
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 import { createFilter } from '@rollup/pluginutils';
 import { ESLint } from 'eslint';
 

diff --git a/packages/eslint/types/index.d.ts b/packages/eslint/types/index.d.ts
@@ -1,6 +1,6 @@
-import { Plugin } from 'rollup';
-import { CLIEngine, ESLint } from 'eslint';
-import { CreateFilter } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
+import type { CLIEngine, ESLint } from 'eslint';
+import type { CreateFilter } from '@rollup/pluginutils';
 
 export interface RollupEslintOptions extends ESLint.Options {
   /**

diff --git a/packages/graphql/test/types.ts b/packages/graphql/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import graphql from '..';
 

diff --git a/packages/graphql/types/index.d.ts b/packages/graphql/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 export interface RollupGraphqlOptions {
   /**

diff --git a/packages/html/src/index.ts b/packages/html/src/index.ts
@@ -1,6 +1,6 @@
 import { extname } from 'path';
 
-import { Plugin, NormalizedOutputOptions, OutputBundle, EmittedAsset } from 'rollup';
+import type { Plugin, NormalizedOutputOptions, OutputBundle, EmittedAsset } from 'rollup';
 
 import type { RollupHtmlOptions, RollupHtmlTemplateOptions } from '../types';
 

diff --git a/packages/html/types/index.d.ts b/packages/html/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin, OutputChunk, OutputAsset, OutputBundle } from 'rollup';
+import type { Plugin, OutputChunk, OutputAsset, OutputBundle } from 'rollup';
 
 export interface RollupHtmlTemplateOptions {
   title: string;

diff --git a/packages/image/test/types.ts b/packages/image/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import image from '..';
 

diff --git a/packages/image/types/index.d.ts b/packages/image/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 interface RollupImageOptions {
   /**

diff --git a/packages/inject/test/types.ts b/packages/inject/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import inject from '..';
 

diff --git a/packages/inject/types/index.d.ts b/packages/inject/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 type Injectment = string | [string, string];
 

diff --git a/packages/json/test/types.ts b/packages/json/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import json from '..';
 

diff --git a/packages/json/types/index.d.ts b/packages/json/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 export interface RollupJsonOptions {
   /**

diff --git a/packages/legacy/test/types.ts b/packages/legacy/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import legacy from '..';
 

diff --git a/packages/legacy/types/index.d.ts b/packages/legacy/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 interface RollupLegacyOptions {
   [key: string]: string | { [key: string]: string };

diff --git a/packages/multi-entry/test/types.ts b/packages/multi-entry/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import multiEntry from '..';
 

diff --git a/packages/multi-entry/types/index.d.ts b/packages/multi-entry/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 interface RollupMultiEntryOptions {
   /**

diff --git a/packages/node-resolve/types/index.d.ts b/packages/node-resolve/types/index.d.ts
@@ -1,4 +1,4 @@
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 export const DEFAULTS: {
   customResolveOptions: {};

diff --git a/packages/pluginutils/src/attachScopes.ts b/packages/pluginutils/src/attachScopes.ts
@@ -1,4 +1,4 @@
-import * as estree from 'estree';
+import type * as estree from 'estree';
 
 import { walk } from 'estree-walker';
 

diff --git a/packages/pluginutils/src/extractAssignedNames.ts b/packages/pluginutils/src/extractAssignedNames.ts
@@ -1,27 +1,35 @@
+import type {
+  ArrayPattern,
+  AssignmentPattern,
+  Identifier,
+  ObjectPattern,
+  RestElement
+} from 'estree';
+
 import type { ExtractAssignedNames } from '../types';
 
 interface Extractors {
   [key: string]: (names: string[], param: any) => void;
 }
 
 const extractors: Extractors = {
-  ArrayPattern(names: string[], param: import('estree').ArrayPattern) {
+  ArrayPattern(names: string[], param: ArrayPattern) {
     for (const element of param.elements) {
       if (element) extractors[element.type](names, element);
     }
   },
 
-  AssignmentPattern(names: string[], param: import('estree').AssignmentPattern) {
+  AssignmentPattern(names: string[], param: AssignmentPattern) {
     extractors[param.left.type](names, param.left);
   },
 
-  Identifier(names: string[], param: import('estree').Identifier) {
+  Identifier(names: string[], param: Identifier) {
     names.push(param.name);
   },
 
   MemberExpression() {},
 
-  ObjectPattern(names: string[], param: import('estree').ObjectPattern) {
+  ObjectPattern(names: string[], param: ObjectPattern) {
     for (const prop of param.properties) {
       // @ts-ignore Typescript reports that this is not a valid type
       if (prop.type === 'RestElement') {
@@ -32,7 +40,7 @@ const extractors: Extractors = {
     }
   },
 
-  RestElement(names: string[], param: import('estree').RestElement) {
+  RestElement(names: string[], param: RestElement) {
     extractors[param.argument.type](names, param.argument);
   }
 };

diff --git a/packages/pluginutils/test/attachScopes.ts b/packages/pluginutils/test/attachScopes.ts
@@ -1,9 +1,10 @@
-import * as estree from 'estree';
+import type * as estree from 'estree';
 
 import test from 'ava';
 import { parse } from 'acorn';
 
-import { attachScopes, AttachedScope } from '../';
+import type { AttachedScope } from '../';
+import { attachScopes } from '../';
 
 test('attaches a scope to the top level', (t) => {
   const ast = parse('var foo;', { ecmaVersion: 2020, sourceType: 'module' });

diff --git a/packages/pluginutils/types/index.d.ts b/packages/pluginutils/types/index.d.ts
@@ -1,4 +1,4 @@
-import { BaseNode } from 'estree';
+import type { BaseNode } from 'estree';
 
 export interface AttachedScope {
   parent?: AttachedScope;

diff --git a/packages/replace/test/types.ts b/packages/replace/test/types.ts
@@ -1,7 +1,7 @@
 // @ts-check
 import { dirname } from 'path';
 
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import replace from '..';
 

diff --git a/packages/replace/types/index.d.ts b/packages/replace/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 type Replacement = string | ((id: string) => string);
 

diff --git a/packages/run/src/index.ts b/packages/run/src/index.ts
@@ -1,7 +1,8 @@
-import { ChildProcess, fork } from 'child_process';
+import type { ChildProcess } from 'child_process';
+import { fork } from 'child_process';
 import { resolve, join, dirname } from 'path';
 
-import { Plugin, RenderedChunk } from 'rollup';
+import type { Plugin, RenderedChunk } from 'rollup';
 
 import type { RollupRunOptions } from '../types';
 

diff --git a/packages/run/types/index.d.ts b/packages/run/types/index.d.ts
@@ -1,6 +1,6 @@
-import { ForkOptions } from 'child_process';
+import type { ForkOptions } from 'child_process';
 
-import { Plugin } from 'rollup';
+import type { Plugin } from 'rollup';
 
 export interface RollupRunOptions extends ForkOptions {
   args?: readonly string[];

diff --git a/packages/strip/test/types.ts b/packages/strip/test/types.ts
@@ -1,4 +1,4 @@
-import { RollupOptions } from 'rollup';
+import type { RollupOptions } from 'rollup';
 
 import strip from '../types/index';
 

diff --git a/packages/strip/types/index.d.ts b/packages/strip/types/index.d.ts
@@ -1,5 +1,5 @@
-import { FilterPattern } from '@rollup/pluginutils';
-import { Plugin } from 'rollup';
+import type { FilterPattern } from '@rollup/pluginutils';
+import type { Plugin } from 'rollup';
 
 interface RollupStripOptions {
   /**