fix(pluginutils)!: don't add cwd to absolute or patterns that start w…

…ith a glob (#517)
rollup · Aug 6, 2020 · d9d2900 · d9d2900
1 parent b819a0f
commit d9d2900
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/pluginutils/src/createFilter.ts b/packages/pluginutils/src/createFilter.ts
@@ -1,4 +1,4 @@
-import { resolve, sep, posix } from 'path';
+import { resolve, sep, posix, isAbsolute } from 'path';
 
 import pm from 'picomatch';
 
@@ -7,7 +7,7 @@ import { CreateFilter } from '../types';
 import ensureArray from './utils/ensureArray';
 
 function getMatcherString(id: string, resolutionBase: string | false | null | undefined) {
-  if (resolutionBase === false) {
+  if (resolutionBase === false || isAbsolute(id) || id.startsWith('*')) {
     return id;
   }
 

diff --git a/packages/pluginutils/test/createFilter.ts b/packages/pluginutils/test/createFilter.ts
@@ -124,3 +124,16 @@ test('handles relative paths', (t) => {
   t.truthy(filter(resolve('a.js')));
   t.falsy(filter(resolve('foo/a.js')));
 });
+
+test('does not add current working directory when pattern is an absolute path', (t) => {
+  const filter = createFilter([resolve('..', '..', '*')]);
+  t.truthy(filter(resolve('..', '..', 'a')));
+  t.truthy(filter(resolve('..', '..', 'b')));
+  t.falsy(filter(resolve('..', 'c')));
+});
+
+test('does not add current working directory when pattern starts with a glob', (t) => {
+  const filter = createFilter(['**/*']);
+  t.truthy(filter(resolve('a')));
+  t.truthy(filter(resolve('..', '..', 'a')));
+});