Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add only option to external #74

Closed
NE-SmallTown opened this issue Dec 3, 2019 · 2 comments · Fixed by #155
Closed

Add only option to external #74

NE-SmallTown opened this issue Dec 3, 2019 · 2 comments · Fixed by #155
Assignees
@shellscape
Labels
🔌 plugin-node-resolve s³ 🔥 nice to have t³ ✨ enhancement x⁵ ⋅ in progress

Comments

@NE-SmallTown
Copy link

NE-SmallTown commented Dec 3, 2019 •
edited
Loading

  • Rollup Plugin Name: node-resolve
  • Rollup Plugin Version: 6.0.0

Feature Use Case

Transfer from rollup/rollup-plugin-node-resolve#245

Feature Proposal

Transfer from rollup/rollup-plugin-node-resolve#245
@shellscape shellscape changed the title [Feature Request][node-resolve plugin] Add only option to external Add only option to external Dec 3, 2019
@shellscape shellscape self-assigned this Jan 9, 2020
@shellscape
Copy link
Collaborator

I've begun work on this as part of a larger refactor. The only option will be renamed to resolveOnly and will mark non-matching dependencies as external as mentioned in rollup/rollup-plugin-node-resolve#245 (comment)

@shellscape
Copy link
Collaborator

@NE-SmallTown I'm going to need a reproduction from you in order to know if I've fixed this successfully. Please choose one of the options for providing a reproduction below:

  1. Using the REPL.it plugin reproduction template at https://repl.it/@rollup/rollup-plugin-repro
  2. Provide a minimal repository link (Read https://git.io/fNzHA for instructions).
    These may take more time to triage than the other options.
  3. Using the REPL at https://rollupjs.org/repl/, or

shellscape added a commit that referenced this issue Jan 9, 2020
@shellscape
chore: fix #74
35428b7
shellscape added a commit that referenced this issue Jan 9, 2020
@shellscape
chore: revert the fix for #74
f4511ca
shellscape added a commit that referenced this issue Jan 9, 2020
@shellscape
fix: fixes #74
c3357b6
@shellscape shellscape mentioned this issue Jan 9, 2020
Merged
9 tasks
shellscape added a commit that referenced this issue Jan 27, 2020
@shellscape
refactor(node-resolve): clean codebase and fix external warnings (#155)
16d5355 
* chore(node-resolve): begin refactor

* chore: fix #74

* docs: improve option descriptions, type desc

* chore: revert the fix for #74

* fix: fixes #74

* test: fix ts tests

* chore: async/await

* chore: remove test:one script

* docs: prefer node-polyfills

* test: isolate failing:

* chore(release): pluginutils v3.0.5

* chore: tests passing with pluginutils update
LarsDenBakker pushed a commit to LarsDenBakker/plugins that referenced this issue Sep 12, 2020
@shellscape @LarsDenBakker
refactor(node-resolve): clean codebase and fix external warnings (rol…
f57c6e7 
…lup#155)

* chore(node-resolve): begin refactor

* chore: fix rollup#74

* docs: improve option descriptions, type desc

* chore: revert the fix for rollup#74

* fix: fixes rollup#74

* test: fix ts tests

* chore: async/await

* chore: remove test:one script

* docs: prefer node-polyfills

* test: isolate failing:

* chore(release): pluginutils v3.0.5

* chore: tests passing with pluginutils update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shellscape shellscape

Labels
🔌 plugin-node-resolve s³ 🔥 nice to have t³ ✨ enhancement x⁵ ⋅ in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(node resolve): clean codebase and fix external warnings rollup/plugins
2 participants
@shellscape @NE-SmallTown