fix(eslint): fix async support for formatter option and TypeScript types
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You just put your PR up yesterday. Please exercise patience. Much of the US is on vacation with their families right now. |
shellscape
requested review from
Andarist,
danielgindi,
lukastaegert and
tjenkinson
shellscape
requested changes
Jan 2, 2023
surmon-china
requested review from
shellscape
and removed request for
danielgindi,
tjenkinson,
Andarist and
lukastaegert
shellscape
reviewed
Jan 6, 2023
shellscape
approved these changes
Jan 13, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
eslintThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
ESLint's
CLIEngineclass has been deprecated, so the latest@types/eslint8.x no longer exports theCLIEnginetype, so the latest version of@rollup/plugin-eslintformatter is inferred to have the wrong argument type.The latest type of
ESLint.Formatterallows to return async values, while the current@rollup/plugin-eslintonly supports sync function.