Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commonjs,dynamic-import-vars,esm-shim,inject,replace,strip): bump magic-string version #1596

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Sep 27, 2023

Rollup Plugin Name: commonjs,esm-shim,dynamic-import-vars,inject,replace,strip

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR updates magic-string from 0.27.0 to 0.30.3. There's some bug fixes.
I think there's no breaking changes included.
https://github.com/Rich-Harris/magic-string/blob/master/CHANGELOG.md

@tada5hi
Copy link
Member

tada5hi commented Oct 7, 2023

@sapphi-red please also dump the magic-string version of the @rollup/plugin-esm-shim plugin.

@sapphi-red sapphi-red force-pushed the fix/bump-magic-string branch from c67b6ef to 9d49b61 Compare October 8, 2023 16:01
@sapphi-red sapphi-red requested a review from tada5hi as a code owner October 8, 2023 16:01
@sapphi-red sapphi-red changed the title fix(commonjs,dynamic-import-vars,inject,replace,strip): bump magic-string version fix(commonjs,dynamic-import-vars,esm-shim,inject,replace,strip): bump magic-string version Oct 8, 2023
@sapphi-red
Copy link
Contributor Author

I've rebased on the master branch and updated magic-string for esm-shim plugin.

@shellscape
Copy link
Collaborator

shellscape commented Oct 15, 2023

thanks!

@sapphi-red sapphi-red deleted the fix/bump-magic-string branch October 15, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants