chore(typescript): Always use ParsedCommandLine #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
force-pushed
the
ts-read-config
branch
from
d12a0cd
to
4ae219a
Compare
shellscape
approved these changes
Jan 18, 2020
Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
NotWoods
force-pushed
the
ts-read-config
branch
from
fb80c7d
to
6e28434
Compare
|
LGTM. Ship it. |
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* chore(typescript): Always use ParsedCommandLine * Update packages/typescript/tsconfig.json Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com> * Add default options and enforce noEmit Co-authored-by: Andrew Powell <shellscape@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Refactors the option parsing to rely more on the Typescript API.
ParsedCommandLinewill later be used for plugin improvements as it includes additional data.This is the first part of getting typechecking to work for the plugin. For that reason, we set up the
fileNamesarray in this PR even though its not used yet.