Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic-import-vars): simplify regex #1751

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Jul 26, 2024

Rollup Plugin Name: dynamic-import-vars

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

n/a

Description

It looks like we can remove the unneeded [] for the regex as it contains only the \w. I discovered this while running eslint-plugin-regexp:

/Users/bjorn/Work/oss/vite/node_modules/.pnpm/@rollup+plugin-dynamic-import-vars@2.1.2_rollup@4.18.1/node_modules/@rollup/plugin-dynamic-import-vars/dist/cjs/index.js
  117:47  error  Unexpected character class with one character class escape. Can remove brackets  regexp/no-useless-character-class

It's not a significant change and unlikely to affect perf, but should help with readability.

@bluwy bluwy requested a review from shellscape as a code owner July 26, 2024 09:59
@shellscape shellscape changed the title refactor(dynamic-import-vars): simplify regex fix(dynamic-import-vars): simplify regex Sep 22, 2024
@shellscape shellscape merged commit 34abd4f into rollup:master Sep 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants