Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pluginutils): optimize createFilter the matching rules when regexp carry flags #1788

Closed

Conversation

btea
Copy link
Contributor

@btea btea commented Oct 16, 2024

Rollup Plugin Name: {pluginutils}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

@btea btea requested a review from shellscape as a code owner October 16, 2024 05:13
@shellscape
Copy link
Collaborator

Thanks, could you roll this into #1787 instead of a separate PR? Both are small enough to be combined.

@btea
Copy link
Contributor Author

btea commented Oct 16, 2024

Okay.

@btea
Copy link
Contributor Author

btea commented Oct 17, 2024

i have updated it.

@btea btea closed this Oct 17, 2024
@btea btea deleted the fix/createFilter-regexp-support-g-flag branch October 18, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants