chore: add @rollup/plugin-html #57

shellscape · 2019-11-27T06:05:02Z

Rollup Plugin Name: `@rollup/plugin-html`

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:

Description

This PR proposes adding a new plugin to the repo. It's based on https://github.com/styleguidist/mini-html-webpack-plugin, with permission, and emits HTML files that can be used for serving a bundle. Coverage is at 100%.

lukastaegert

Before this plugin should be released, there is one really important thing IMO that should be handled and that is emitting the right html based on the format (you get it here via output.format). Not all formats are equally useable, and for other formats, the output needs to be adjusted. Here is a rundown of what could happen by format:

es (note that for plugins, esm is called es for historical reasons): Generated script tags MUST receive the type="module" attribute! Otherwise, this is a great format to use.
iife, umd: Nothing special needs to be done here. Those formats are designed to be used by regular script tags. If there is more than one input, Rollup will throw an error.
cjs: This should throw an error that it is not supported.
amd: This should probably use RequireJS semantics. This allows only for a single entry script tag. If more entry chunks are emitted, these need to be loaded via a proxy file. Also, requireJS needs to be a dependency and probably added to the build: https://requirejs.org/docs/start.html. If this is too much for now, maybe just throw that it is not yet supported.
system: You should add a separate script tag first that adds the s.js minimal loader. Then further script tags look like this: <script>System.import('./file.js')</script>. Again if this is too much, you might throw an error that this format is not yet supported.

packages/html/rollup.config.js

packages/html/lib/index.js

lukastaegert · 2019-11-27T06:34:02Z

packages/html/lib/index.js

+      const htmlFile = {
+        type: 'asset',
+        source,
+        name: 'Rollup HTML Asset',


The name will be ignored as a fileName is provided.

Noted. We need to update the Rollup docs as this is a copy/paste/modify from them. I'll see about doing that this week.

It is written in the first paragraph after the code block here: https://rollupjs.org/guide/en/#thisemitfileemittedfile-emittedchunk--emittedasset--string

I did read that, but with the code sample above that having both and both being optional, I had assumed it would be prudent to set name in the event that something was inspecting it down the line. Some extra verbiage there could be useful to point out there's no need to set the other property.

True. It does not hurt adding the name, it is just ignored.

lukastaegert · 2019-11-27T07:02:19Z

packages/html/lib/index.js

@@ -0,0 +1,87 @@
+const { extname } = require('path');
+
+const getFiles = (bundle) => {


This function should ONLY get entry point files (isEntry: true) and ignore the rest. Reason:

For IIFE and UMD formats, there will only be a single entry point anyway

All other formats import their dependencies themselves. If you add all files as script tags, you will at least destroy dynamic lazy loading of chunks (if it works at all).

Disagree here. Various assets can be added to a bundle's files via plugins, and we should pick those up. CSS is the major example here.

This function puts all files .js files into an array and throws away all meta information. It is virtually impossible to distiguish the auto-generated chunks from the entry points. This makes the plugin rather useless for code-splitting IMO. Either you provide some meta information, or you ignore the non-entry chunks. I would be very confused if a CSS plugin was broken if you ignored the auto-generated chunks, as they are still imported by the main JavaScript. And maybe this even breaks CSS plugins in so far as maybe their chunks are meant to be loaded dynamically together with their content while you make them load up-front instead.

That makes the case for providing the bundle metadata to the template option function for complex builds that the default template doesn't suit.

That would be sufficient

With regard to my initial comment, maybe I mis-stated what I mean: This function should of course return all assets, but with regard to chunks, it should only return entry chunks, as all non-entry chunks (read: .js files) will be loaded automatically by the entry chunks, no additional work necessary. But additionally having the bundle available to the template still would not hurt.

shellscape · 2019-11-27T07:34:07Z

@lukastaegert I will look into and implement the various format warnings that we discussed via chat, prior to merge of this.

es (note that for plugins, esm is called es for historical reasons): Generated script tags MUST receive the type="module" attribute! Otherwise, this is a great format to use.

For this I think we can mutate the default attributes option internally. That's an easy support.

packages/html/README.md

…html

lukastaegert

The changes look good to me and should produce sensible output 👍
Also the warning is very good.

shellscape · 2019-11-29T05:50:04Z

@lukastaegert great, thanks. we're going to do an improvement round after migration of the existing plugins and I'll slate some time to working on templates we can export for the unsupported formats.

Extract mocha options into their own file.

* initial commit * allow include/exclude * admin and README * -> 1.0.0 * fix prepublish script * Update README.md * make compatible with babel 6 * -> 2.0.0 * Merge pull request #6 from Victorystick/patch-1 Add repository * Merge pull request #8 from TrySound/tidy-up Tidy up * -> 2.0.1 * remove unnecessary logging * bump up timeout, to try and fix tests on 0.12 * generate sourcemaps by default * -> 2.1.0 * test for #16 * run preflight check per file – fixes #16 * -> 2.2.0 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * debug travis test failure * add missing devDep * add appveyor config * es6ify source code * fix tests on windows? * install babel-register * Merge pull request #19 from rollup/gh-17 Better handling of helpers * -> 2.3.0 * -> 2.3.2 * fix incomprehensible travis test failure * fix helper renaming (#22) * -> 2.3.3 * fix failing preflight check in absence of class transformer (closes #23) * -> 2.3.4 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * use class transformer local to plugin * -> 2.3.5 * typo * verify warnings are correct * prevent unnecessary `var babelHelpers = {}` * update rollup * Merge pull request #29 from rollup/fix-preflight-check-caching Ensure caching works properly for repeated calls with the same `dir`. * -> 2.3.6 * remove some debugging code * Merge pull request #31 from ericf/fix-babel-helper-bindings Fix Babel helper binding renaming * -> 2.3.7 * -> 2.3.8 * external-helpers-2 -> external-helpers * Merge remote-tracking branch 'ericf/remove-babel-helper-renaming' * -> 2.3.9 * Update README.md * Merge pull request #41 from joeldenning/external-helpers Adding support for referencing external, global helpers * -> 2.4.0 * import helpers, so that transform function is pure * update test * update deps, switch from babel to buble * -> v2.5.0 * install buble * Merge pull request #57 from rollup/mocha-opts Extract mocha options into their own file. * Merge pull request #56 from rollup/gh-55 typeof * -> v2.5.1 * Update dependencies. * dont export _typeof, _extends etc * use NUL convention for helper name * -> v2.6.0 * -> v2.6.1 * typo * Merge pull request #73 from zeitiger/updateDocumentationForBabel63 update README for new Babel 6.13 * update dependencies * Merge branch 'issue/81-generates-sourcemap-by-default-spec-failing' of https://github.com/snuggs/rollup-plugin-babel into snuggs-issue/81-generates-sourcemap-by-default-spec-failing * update build matrix * update appveyor matrix * update babel-preset-es2015-rollup for tests * test with babel-preset-es2015-rollup@3 * Merge pull request #90 from DrewML/update-babel-warning Remove recommendation to change Babel preset from lib * Merge pull request #85 from rollup/use-onwarn-if-available Use options.onwarn if available * Merge pull request #94 from rtsao/patch-1 Updated external-helpers package name in README * Merge pull request #99 from AMcBain/master Ignore Babel 'only' options property for preflight checks. * Merge pull request #92 from sorgloomer/master Added externalHelpersWhitelist option * -> v2.7.0 * Merge pull request #108 from rollup/gh-102 remove ignore from preflight options * Merge pull request #107 from rollup/gh-105 fix duplicated helper warnings with runtime helpers * Merge pull request #109 from rollup/gh-95 Allow custom runtime-helpers moduleName * -> v2.7.1 * -> v2.7.1 * fix prepublish script * Merge pull request #117 from vinkla/patch-1 Simplify repository config * make use of object-assign (#118) Delete assign from utils.js * Breaking: Babel 7 alpha update (#139) Breaking: Babel 7 alpha update * 3.0.0-alpha.12 * update to babel 7 alpha.15 * 3.0.0-alpha.15 * use alpha.17 (#151) * 3.0.0-alpha.17 * Peer dep (#153) * make an inline plugin for the preflight check, make babel-core a peerDep * turn babel-core dep into a peerDep * fix reference to old class plugin * update lock file, ignore log files * 3.0.0 * 3.0.0 changelog [skip ci] * fix transform (#154) * 3.0.1 * changelog [skip ci] * Fix regression with Babel 6 (#158) * Fix regression with Babel 6 Since in Babel 6 it is not supported to replace the argument of a default export declaration with an expression, use a custom "replaceWith" function which handles also that case. Fixes #155, fixes #156. * Run tests using both Babel 7 and Babel 6 * 3.0.2 * Fixed support for babel 7 (#170) * Fixed support for babel 7 * feat(babel): Use scoped babel packages BREAKING CHANGE: This now requires scoped babel packages to be used. * Updated to @babel/plugin-proposal-decorators * Replace es2015 preset with env (#174) * Merge pull request #150 from wmhilton/patch-1 Use "module" in addition to "jsnext:main" * 4.0.0-beta.0 * Merge pull request #175 from rollup/existentialism-patch-1 Fix small grammar nit in external-helpers warning * Update README.md (#163) Added a missing word and fixed few tiny errors * Update rollup dependencies and fix tests and build * merge master -> update-deps * Merge pull request #147 from kopax/master clarify README.md showing an example excluding helpers with a variable set to true * Refactored async tests to bare promises to fix them on older nodes (#194) * Fixed issue with reading .code from null (untranspiled file due to ignore/only options) (#193) * 4.0.0-beta.2 * Restore NUL convention for helper name (#198) The null character `\0` seems to have first been introduced by d169da1. Fixes #197 * 4.0.0-beta.3 * bumped babel deps * 4.0.0-beta.4 * Fix npm beta label in README (#207) Previously, the instructions for usage with Babel 7 was to install the plugin with the label "next" which doesn't exist. The correct label is "beta". * Bumped version of babel deps * Tweaked preflight check (fixes #211) * 4.0.0-beta.5 * Drop node@4 support * Bumped all dependencies. (#219) * Update pinned version of babel. * Update all development dependencies so this plugin is tested against current software. * Make changes to test needed by updated rollup. * Add node.js 10 to testing. * Delegate warnings and errors reporting to rollup (#223) * Delegate warnings and errors reporting to rollup * Fixed mocha deprecation warn * Merge branch 'option-cleanup' * Cache preflight check results per plugin's instance (#224) * Merge remote-tracking branch 'miketrexler/modules-false-docs' * Tweaked babelrc: false workaround recommendation * Throw when used with module transform BEFORE throwing about unexpected situation (#225) * Updated deps: eslint, rollup, pluginutils - tests still green * Fix for issue #220: Check ESM first before checking inheritance helper + Expect imported package instead of variable name which feels safer for checking runtime usage. * Fine-tuned runtime check to allow custom helper name. Issue #220. * Added new previously failing test for issue #220. * Made hints related to babel modules:false more explicit and helpful. * Extracted error messages into variables, splitted by lines for better code readability. Template literals are not allowed right now by linting. * Removed irrelevant babel plugin from a test case * 4.0.0-beta.6 * Fixed runtime helpers detection with useESModules & useBuiltIns options (#226) * Add support for esm and builtin runtime helpers This diff adds support for `useESModules` and `useBuiltIns` options in transform-runtime plugin which injects paths with `es6` and `builtin` suffixes. * Fix lint * 4.0.0-beta.7 * Improve distributed dist directory (#234) * Improve dist - rename .es.js to .esm.js - removed jsnext:main - simplified rollup config * Tweak files and revert external * Upgrade babel deps and tweak preflight check according to latest changes (#233) * Upgrade babel and tweak according changes - simplified preflight check for runtime helpers - removed moduleName test - tweaked removed options * Fix lint * Regenerate lockfile * 4.0.0-beta.8 * Transpile only default babel extensions, allow for custom extensions option (fixes #111) * Pass appropriate caller config to babel.transform (#238) * 4.0.0 * Update docs regarding babel versions and matching plugin versions * Bumped babel deps * 4.0.1 * Fix `rollup` peer dependency (#240) Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof. * 4.0.2 * Tweaked README, added 4.0 CHANGELOG notes * Fixed fallbackClassTransform * 4.0.3-0 * 4.0.3 * Fix preflightChecks for ignored files * Setup prettier * Run prettier over the repo files * Tweak eslint rules to stop conflicting with prettier output * 4.1.0-0 * Add options.extensions to README (#256) * Upgraded husky * Remove babel 6 test from AppVeyor (#263) * Remove babel 6 test from appveyor * Remove reduntant echo * Fix indentation in examples of configuration in readme (#266) * Return null from the transform hook when it doesn't transform anything * 4.1.0-1 * 4.1.0 * Reword 'except' as 'plus' (#280) * Allow rollup@1 as peer dep * 4.2.0 * Update devDep to rollup@1 * Fail build when trying plugin tries to add non-existent helper (#290) * Merge branch 'custom-builder' * 4.3.0 * Fix reference to the plugin in the README * Update CHANGELOG * Add js extention to helper file (#296) * 4.3.1 * Add note to CHANGELOG about v4.3.1 * Fix usage with externalHelpers flag * 4.3.2 * Update CHANGELOG with note about 4.3.2 * chore: audit fixes * chore: npm audit fix * Update rollup-pluginutils@2.8.1 (#311) * Update rollup-pluginutils@2.8.1 Update `rollup-pluginutils` to a version which contains a fix for the `braces` package vulnerability. https://nodesecurity.io/advisories/786 * Regenerate package-lock * 4.3.3 * Add possibility to run babel per output (#333) * Update dependencies * First draft for using the plugin to transform output options * Deduplicate code * Pass correct context to transformCode * Update documentation and add chunking test * Fix Windows tests * Address review comments * No longer respect "file" and "dir" options and adjust docs * Use plugin.generated for output plugin * Add warning for formats other than ESM or CJS, update docs * Throw for not recommended formats but add an override option. * Address review comments * Fixed issue with incorrect caller data being passed to Babel by generated output plugins * Reduce information about external helpers as those are not recommended * Add `sourceType` when transforming the output. * Update test and readme for runtime helpers * Add note about babelrc files * Do not load config files by default * Update dependencies * Note minimal Rollup version for output plugins * Merge branch 'tla' # Conflicts: # src/index.js * Use babel.transformAsync (#331) * Use rimraf in prebuild script (#335) * use rimraf * move to dev dep * Drop node 6 support, use untranspiled async/await syntax * Recommend explicit babelHelpers option to be used (#339) * Refactored babelHelpers settings - require user declaring which kind of helpers they want to use * Adjust tests to new babelHelpers logic * Keep UNRESOLVED_IMPORT warnings out of the console when running tests * 5.0.0-alpha.0 * Rename skipBabelHelpersCheck to skipPreflightCheck * Make missing babelHelpers a warning * 5.0.0-alpha.1 * Use transformAsync in preflight check * Tweak implementation of the preflight helpers check * Add example to the README how to use the plugin with the Rollup CLI (#327) * explain how to configure the rollup cli * Tweak README * Dont crash on minified code when performing preflight check * Rename rollup-plugin-babel directory to babel * Remove tooling configs not needed in monorepo * Drop transpilation of rollup-plugin-babel, set engines to node@>=10 * Reformat babel plugin with monorepo prettier & ESLint rules * Use exports: named for babel plugin CJS bundle * Migrate babel plugin tests to use ava * Use pnpm to run npm scripts in babel plugin * Use scoped @rollup/plugin-json in babel plugin * Remove unnecessary eslint-disable comment * Update babel plugin metadata to point to monorepo * Remove LICENSE file from babel plugin, pnpm will use the root one when publishing * Move .eslints with turned off rules to fixtures directory * Move loop counter declaration * use getCode helper where possible * Use more proper throwsAsync & notThrowsAsync assertions * Transpile @rollup/plugin-babel using itself * Migrate to use @rollup/pluginutils in babel plugin * Set peer dep range for rollup to ^1.20.0 to align with the rest of plugins * Fix homepage in babel plugin package.json * Include repository reference in test descriptionbs refering to issue numbers * Change URLs in the source files to point to a plugins repo * Change rollup-plugin-babel to @rollup/plugin-babel in source files * cleanup README a little bit * Tweak "Modules" section, remove mentions of Babel 6 from there * Fix some more references to rollup-plugin-babel * Add badges to the top of the README * Adhere to the README template used by other plugins * Tweak CHANGELOG * Mention Babel plugin in the root README * Add publishConfig to package.json of the Babel plugin * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <toakes@mozilla.com> * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <toakes@mozilla.com> * Fixed how @rollup/pluginutils are used * Allow Rollup 2 in peer dependency range * Refactor babel plugin exports shape * tweak usage example in the babel plugin README * Align package.json of Babel plugin to existing package.json files in the monorepo * Update @rollup/pluginutils in the Babel plugin * Add new changelog entries to the Babel plugin * Move babelHelpers recommendation text to the README * Fix typo in the README * chore: remove prepare script, build in prepublishOnly This avoids fresh `pnpm install` problems where the build runs before babel plugins are installed. * Upgrade @babel/preset-env in babel plugin Co-authored-by: Rich-Harris <richard.a.harris@gmail.com> Co-authored-by: Oskar Segersvärd <victorystick@gmail.com> Co-authored-by: Brian Donovan <me@brian-donovan.com> Co-authored-by: Yuta Hiroto <git@about-hiroppy.com> Co-authored-by: Henry Zhu <hi@henryzoo.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Denis <carriere.denis@gmail.com> Co-authored-by: Daniel Tschinder <daniel.tschinder@researchgate.net> Co-authored-by: Brian Ng <bng412@gmail.com> Co-authored-by: Roy Revelt <roy@codsen.com> Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> Co-authored-by: Can Göktas <cangoektas@users.noreply.github.com> Co-authored-by: Corey Farrell <git@cfware.com> Co-authored-by: Sebastian Werner <s.werner@sebastian-software.de> Co-authored-by: Bogdan Chadkin <trysound@yandex.ru> Co-authored-by: ylemkimon <mail@ylem.kim> Co-authored-by: Kristoffer <denkristoffer@users.noreply.github.com> Co-authored-by: Shadab Khan <shadab.2005@gmail.com> Co-authored-by: Adam Gołąb <adam@brainhub.pl> Co-authored-by: Kinrany <kinrany@yandex.com> Co-authored-by: Mike Heddes <mikeheddes@gmail.com> Co-authored-by: shellscape <andrew@shellscape.org> Co-authored-by: Ryan Walters <shout@ryanwalters.co> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com> Co-authored-by: Troy Rhinehart <troy.rhinehart@gmail.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Tiger Oakes <toakes@mozilla.com>

* initial commit * allow include/exclude * admin and README * -> 1.0.0 * fix prepublish script * Update README.md * make compatible with babel 6 * -> 2.0.0 * Merge pull request rollup#6 from Victorystick/patch-1 Add repository * Merge pull request rollup#8 from TrySound/tidy-up Tidy up * -> 2.0.1 * remove unnecessary logging * bump up timeout, to try and fix tests on 0.12 * generate sourcemaps by default * -> 2.1.0 * test for rollup#16 * run preflight check per file – fixes rollup#16 * -> 2.2.0 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * debug travis test failure * add missing devDep * add appveyor config * es6ify source code * fix tests on windows? * install babel-register * Merge pull request rollup#19 from rollup/rollupgh-17 Better handling of helpers * -> 2.3.0 * -> 2.3.2 * fix incomprehensible travis test failure * fix helper renaming (rollup#22) * -> 2.3.3 * fix failing preflight check in absence of class transformer (closes rollup#23) * -> 2.3.4 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * use class transformer local to plugin * -> 2.3.5 * typo * verify warnings are correct * prevent unnecessary `var babelHelpers = {}` * update rollup * Merge pull request rollup#29 from rollup/fix-preflight-check-caching Ensure caching works properly for repeated calls with the same `dir`. * -> 2.3.6 * remove some debugging code * Merge pull request rollup#31 from ericf/fix-babel-helper-bindings Fix Babel helper binding renaming * -> 2.3.7 * -> 2.3.8 * external-helpers-2 -> external-helpers * Merge remote-tracking branch 'ericf/remove-babel-helper-renaming' * -> 2.3.9 * Update README.md * Merge pull request rollup#41 from joeldenning/external-helpers Adding support for referencing external, global helpers * -> 2.4.0 * import helpers, so that transform function is pure * update test * update deps, switch from babel to buble * -> v2.5.0 * install buble * Merge pull request rollup#57 from rollup/mocha-opts Extract mocha options into their own file. * Merge pull request rollup#56 from rollup/rollupgh-55 typeof * -> v2.5.1 * Update dependencies. * dont export _typeof, _extends etc * use NUL convention for helper name * -> v2.6.0 * -> v2.6.1 * typo * Merge pull request rollup#73 from zeitiger/updateDocumentationForBabel63 update README for new Babel 6.13 * update dependencies * Merge branch 'issue/81-generates-sourcemap-by-default-spec-failing' of https://github.com/snuggs/rollup-plugin-babel into snuggs-issue/81-generates-sourcemap-by-default-spec-failing * update build matrix * update appveyor matrix * update babel-preset-es2015-rollup for tests * test with babel-preset-es2015-rollup@3 * Merge pull request rollup#90 from DrewML/update-babel-warning Remove recommendation to change Babel preset from lib * Merge pull request rollup#85 from rollup/use-onwarn-if-available Use options.onwarn if available * Merge pull request rollup#94 from rtsao/patch-1 Updated external-helpers package name in README * Merge pull request rollup#99 from AMcBain/master Ignore Babel 'only' options property for preflight checks. * Merge pull request rollup#92 from sorgloomer/master Added externalHelpersWhitelist option * -> v2.7.0 * Merge pull request rollup#108 from rollup/rollupgh-102 remove ignore from preflight options * Merge pull request rollup#107 from rollup/rollupgh-105 fix duplicated helper warnings with runtime helpers * Merge pull request rollup#109 from rollup/rollupgh-95 Allow custom runtime-helpers moduleName * -> v2.7.1 * -> v2.7.1 * fix prepublish script * Merge pull request rollup#117 from vinkla/patch-1 Simplify repository config * make use of object-assign (rollup#118) Delete assign from utils.js * Breaking: Babel 7 alpha update (rollup#139) Breaking: Babel 7 alpha update * 3.0.0-alpha.12 * update to babel 7 alpha.15 * 3.0.0-alpha.15 * use alpha.17 (rollup#151) * 3.0.0-alpha.17 * Peer dep (rollup#153) * make an inline plugin for the preflight check, make babel-core a peerDep * turn babel-core dep into a peerDep * fix reference to old class plugin * update lock file, ignore log files * 3.0.0 * 3.0.0 changelog [skip ci] * fix transform (rollup#154) * 3.0.1 * changelog [skip ci] * Fix regression with Babel 6 (rollup#158) * Fix regression with Babel 6 Since in Babel 6 it is not supported to replace the argument of a default export declaration with an expression, use a custom "replaceWith" function which handles also that case. Fixes rollup#155, fixes rollup#156. * Run tests using both Babel 7 and Babel 6 * 3.0.2 * Fixed support for babel 7 (rollup#170) * Fixed support for babel 7 * feat(babel): Use scoped babel packages BREAKING CHANGE: This now requires scoped babel packages to be used. * Updated to @babel/plugin-proposal-decorators * Replace es2015 preset with env (rollup#174) * Merge pull request rollup#150 from wmhilton/patch-1 Use "module" in addition to "jsnext:main" * 4.0.0-beta.0 * Merge pull request rollup#175 from rollup/existentialism-patch-1 Fix small grammar nit in external-helpers warning * Update README.md (rollup#163) Added a missing word and fixed few tiny errors * Update rollup dependencies and fix tests and build * merge master -> update-deps * Merge pull request rollup#147 from kopax/master clarify README.md showing an example excluding helpers with a variable set to true * Refactored async tests to bare promises to fix them on older nodes (rollup#194) * Fixed issue with reading .code from null (untranspiled file due to ignore/only options) (rollup#193) * 4.0.0-beta.2 * Restore NUL convention for helper name (rollup#198) The null character `\0` seems to have first been introduced by d169da1. Fixes rollup#197 * 4.0.0-beta.3 * bumped babel deps * 4.0.0-beta.4 * Fix npm beta label in README (rollup#207) Previously, the instructions for usage with Babel 7 was to install the plugin with the label "next" which doesn't exist. The correct label is "beta". * Bumped version of babel deps * Tweaked preflight check (fixes rollup#211) * 4.0.0-beta.5 * Drop node@4 support * Bumped all dependencies. (rollup#219) * Update pinned version of babel. * Update all development dependencies so this plugin is tested against current software. * Make changes to test needed by updated rollup. * Add node.js 10 to testing. * Delegate warnings and errors reporting to rollup (rollup#223) * Delegate warnings and errors reporting to rollup * Fixed mocha deprecation warn * Merge branch 'option-cleanup' * Cache preflight check results per plugin's instance (rollup#224) * Merge remote-tracking branch 'miketrexler/modules-false-docs' * Tweaked babelrc: false workaround recommendation * Throw when used with module transform BEFORE throwing about unexpected situation (rollup#225) * Updated deps: eslint, rollup, pluginutils - tests still green * Fix for issue rollup#220: Check ESM first before checking inheritance helper + Expect imported package instead of variable name which feels safer for checking runtime usage. * Fine-tuned runtime check to allow custom helper name. Issue rollup#220. * Added new previously failing test for issue rollup#220. * Made hints related to babel modules:false more explicit and helpful. * Extracted error messages into variables, splitted by lines for better code readability. Template literals are not allowed right now by linting. * Removed irrelevant babel plugin from a test case * 4.0.0-beta.6 * Fixed runtime helpers detection with useESModules & useBuiltIns options (rollup#226) * Add support for esm and builtin runtime helpers This diff adds support for `useESModules` and `useBuiltIns` options in transform-runtime plugin which injects paths with `es6` and `builtin` suffixes. * Fix lint * 4.0.0-beta.7 * Improve distributed dist directory (rollup#234) * Improve dist - rename .es.js to .esm.js - removed jsnext:main - simplified rollup config * Tweak files and revert external * Upgrade babel deps and tweak preflight check according to latest changes (rollup#233) * Upgrade babel and tweak according changes - simplified preflight check for runtime helpers - removed moduleName test - tweaked removed options * Fix lint * Regenerate lockfile * 4.0.0-beta.8 * Transpile only default babel extensions, allow for custom extensions option (fixes rollup#111) * Pass appropriate caller config to babel.transform (rollup#238) * 4.0.0 * Update docs regarding babel versions and matching plugin versions * Bumped babel deps * 4.0.1 * Fix `rollup` peer dependency (rollup#240) Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof. * 4.0.2 * Tweaked README, added 4.0 CHANGELOG notes * Fixed fallbackClassTransform * 4.0.3-0 * 4.0.3 * Fix preflightChecks for ignored files * Setup prettier * Run prettier over the repo files * Tweak eslint rules to stop conflicting with prettier output * 4.1.0-0 * Add options.extensions to README (rollup#256) * Upgraded husky * Remove babel 6 test from AppVeyor (rollup#263) * Remove babel 6 test from appveyor * Remove reduntant echo * Fix indentation in examples of configuration in readme (rollup#266) * Return null from the transform hook when it doesn't transform anything * 4.1.0-1 * 4.1.0 * Reword 'except' as 'plus' (rollup#280) * Allow rollup@1 as peer dep * 4.2.0 * Update devDep to rollup@1 * Fail build when trying plugin tries to add non-existent helper (rollup#290) * Merge branch 'custom-builder' * 4.3.0 * Fix reference to the plugin in the README * Update CHANGELOG * Add js extention to helper file (rollup#296) * 4.3.1 * Add note to CHANGELOG about v4.3.1 * Fix usage with externalHelpers flag * 4.3.2 * Update CHANGELOG with note about 4.3.2 * chore: audit fixes * chore: npm audit fix * Update rollup-pluginutils@2.8.1 (rollup#311) * Update rollup-pluginutils@2.8.1 Update `rollup-pluginutils` to a version which contains a fix for the `braces` package vulnerability. https://nodesecurity.io/advisories/786 * Regenerate package-lock * 4.3.3 * Add possibility to run babel per output (rollup#333) * Update dependencies * First draft for using the plugin to transform output options * Deduplicate code * Pass correct context to transformCode * Update documentation and add chunking test * Fix Windows tests * Address review comments * No longer respect "file" and "dir" options and adjust docs * Use plugin.generated for output plugin * Add warning for formats other than ESM or CJS, update docs * Throw for not recommended formats but add an override option. * Address review comments * Fixed issue with incorrect caller data being passed to Babel by generated output plugins * Reduce information about external helpers as those are not recommended * Add `sourceType` when transforming the output. * Update test and readme for runtime helpers * Add note about babelrc files * Do not load config files by default * Update dependencies * Note minimal Rollup version for output plugins * Merge branch 'tla' # Conflicts: # src/index.js * Use babel.transformAsync (rollup#331) * Use rimraf in prebuild script (rollup#335) * use rimraf * move to dev dep * Drop node 6 support, use untranspiled async/await syntax * Recommend explicit babelHelpers option to be used (rollup#339) * Refactored babelHelpers settings - require user declaring which kind of helpers they want to use * Adjust tests to new babelHelpers logic * Keep UNRESOLVED_IMPORT warnings out of the console when running tests * 5.0.0-alpha.0 * Rename skipBabelHelpersCheck to skipPreflightCheck * Make missing babelHelpers a warning * 5.0.0-alpha.1 * Use transformAsync in preflight check * Tweak implementation of the preflight helpers check * Add example to the README how to use the plugin with the Rollup CLI (rollup#327) * explain how to configure the rollup cli * Tweak README * Dont crash on minified code when performing preflight check * Rename rollup-plugin-babel directory to babel * Remove tooling configs not needed in monorepo * Drop transpilation of rollup-plugin-babel, set engines to node@>=10 * Reformat babel plugin with monorepo prettier & ESLint rules * Use exports: named for babel plugin CJS bundle * Migrate babel plugin tests to use ava * Use pnpm to run npm scripts in babel plugin * Use scoped @rollup/plugin-json in babel plugin * Remove unnecessary eslint-disable comment * Update babel plugin metadata to point to monorepo * Remove LICENSE file from babel plugin, pnpm will use the root one when publishing * Move .eslints with turned off rules to fixtures directory * Move loop counter declaration * use getCode helper where possible * Use more proper throwsAsync & notThrowsAsync assertions * Transpile @rollup/plugin-babel using itself * Migrate to use @rollup/pluginutils in babel plugin * Set peer dep range for rollup to ^1.20.0 to align with the rest of plugins * Fix homepage in babel plugin package.json * Include repository reference in test descriptionbs refering to issue numbers * Change URLs in the source files to point to a plugins repo * Change rollup-plugin-babel to @rollup/plugin-babel in source files * cleanup README a little bit * Tweak "Modules" section, remove mentions of Babel 6 from there * Fix some more references to rollup-plugin-babel * Add badges to the top of the README * Adhere to the README template used by other plugins * Tweak CHANGELOG * Mention Babel plugin in the root README * Add publishConfig to package.json of the Babel plugin * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <toakes@mozilla.com> * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <toakes@mozilla.com> * Fixed how @rollup/pluginutils are used * Allow Rollup 2 in peer dependency range * Refactor babel plugin exports shape * tweak usage example in the babel plugin README * Align package.json of Babel plugin to existing package.json files in the monorepo * Update @rollup/pluginutils in the Babel plugin * Add new changelog entries to the Babel plugin * Move babelHelpers recommendation text to the README * Fix typo in the README * chore: remove prepare script, build in prepublishOnly This avoids fresh `pnpm install` problems where the build runs before babel plugins are installed. * Upgrade @babel/preset-env in babel plugin Co-authored-by: Rich-Harris <richard.a.harris@gmail.com> Co-authored-by: Oskar Segersvärd <victorystick@gmail.com> Co-authored-by: Brian Donovan <me@brian-donovan.com> Co-authored-by: Yuta Hiroto <git@about-hiroppy.com> Co-authored-by: Henry Zhu <hi@henryzoo.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Denis <carriere.denis@gmail.com> Co-authored-by: Daniel Tschinder <daniel.tschinder@researchgate.net> Co-authored-by: Brian Ng <bng412@gmail.com> Co-authored-by: Roy Revelt <roy@codsen.com> Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> Co-authored-by: Can Göktas <cangoektas@users.noreply.github.com> Co-authored-by: Corey Farrell <git@cfware.com> Co-authored-by: Sebastian Werner <s.werner@sebastian-software.de> Co-authored-by: Bogdan Chadkin <trysound@yandex.ru> Co-authored-by: ylemkimon <mail@ylem.kim> Co-authored-by: Kristoffer <denkristoffer@users.noreply.github.com> Co-authored-by: Shadab Khan <shadab.2005@gmail.com> Co-authored-by: Adam Gołąb <adam@brainhub.pl> Co-authored-by: Kinrany <kinrany@yandex.com> Co-authored-by: Mike Heddes <mikeheddes@gmail.com> Co-authored-by: shellscape <andrew@shellscape.org> Co-authored-by: Ryan Walters <shout@ryanwalters.co> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com> Co-authored-by: Troy Rhinehart <troy.rhinehart@gmail.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Tiger Oakes <toakes@mozilla.com>

shellscape added 2 commits November 26, 2019 23:01

chore: add @rollup/plugin-html

8c96ec1

docs: add attribution

9773508

shellscape added the pr¹ 🔧 chore label Nov 27, 2019

shellscape requested review from lukastaegert and a team November 27, 2019 06:05

chore: fix ci:lint script

abf179f

lukastaegert requested changes Nov 27, 2019

View reviewed changes

chore: nuke rollup.config.js, was a leftover from tests

5670a79

lukastaegert approved these changes Nov 27, 2019

View reviewed changes

bebraw reviewed Nov 27, 2019

View reviewed changes

packages/html/README.md Outdated Show resolved Hide resolved

packages/html/README.md Outdated Show resolved Hide resolved

shellscape and others added 6 commits November 27, 2019 09:15

Update packages/html/README.md

7dc69ec

Update packages/html/README.md

20598ef

test: test output formats, warnings. update docs for formats

36bb3a2

chore: Merge branch 'add/html' of github.com:rollup/plugins into add/…

6ef057f

…html

chore: add bundle to template params, no-write tests

d757c3c

chore: remove --u from test script

83b7e72

lukastaegert approved these changes Nov 29, 2019

View reviewed changes

shellscape merged commit 144b4a4 into master Nov 29, 2019

shellscape deleted the add/html branch November 29, 2019 05:50

Andarist pushed a commit that referenced this pull request Dec 23, 2019

Merge pull request #57 from rollup/mocha-opts

77976ac

Extract mocha options into their own file.

Andarist pushed a commit that referenced this pull request Dec 25, 2019

Merge pull request #57 from rollup/mocha-opts

043aaa4

Extract mocha options into their own file.

Andarist pushed a commit that referenced this pull request Apr 12, 2020

Merge pull request #57 from rollup/mocha-opts

30b1a27

Extract mocha options into their own file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add @rollup/plugin-html #57

chore: add @rollup/plugin-html #57

shellscape commented Nov 27, 2019

lukastaegert left a comment

lukastaegert Nov 27, 2019

shellscape Nov 27, 2019

lukastaegert Nov 27, 2019

shellscape Nov 27, 2019

lukastaegert Nov 27, 2019

lukastaegert Nov 27, 2019

shellscape Nov 27, 2019

lukastaegert Nov 27, 2019

shellscape Nov 27, 2019

lukastaegert Nov 27, 2019

lukastaegert Nov 27, 2019

shellscape commented Nov 27, 2019 •

edited

Loading

lukastaegert left a comment

shellscape commented Nov 29, 2019

		@@ -0,0 +1,87 @@
		const { extname } = require('path');

		const getFiles = (bundle) => {

chore: add @rollup/plugin-html #57

chore: add @rollup/plugin-html #57

Conversation

shellscape commented Nov 27, 2019

Rollup Plugin Name: @rollup/plugin-html

Description

lukastaegert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shellscape commented Nov 27, 2019 • edited Loading

lukastaegert left a comment

Choose a reason for hiding this comment

shellscape commented Nov 29, 2019

Rollup Plugin Name: `@rollup/plugin-html`

shellscape commented Nov 27, 2019 •

edited

Loading