Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(typescript): bump TypeScript version #818

Merged
merged 2 commits into from
Mar 10, 2021
Merged

chore(typescript): bump TypeScript version #818

merged 2 commits into from
Mar 10, 2021

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Feb 24, 2021 •
edited
Loading

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: #287

Description

Closes #287 now that TypeScript 4.2 has come out

@benmccann
Copy link
Contributor Author

I've updated this PR to revert #794. It was making all tests fail with TypeScript 4.2. It also seems unnecessary because the PR description says "The issue is that without a directory from which to read the tsconfig.json file, and without those root options, TS doesn't know where to start things off." However, that's exactly the issue that TypeScript 4.2 is fixing.

@benmccann benmccann mentioned this pull request Feb 24, 2021
Merged
@shellscape
Copy link
Collaborator

shellscape commented Mar 10, 2021 •
edited
Loading

@benmccann some comments in #287 have alluded to 4.2 not fixing that particular issue, so we'll need to keep an eye out for use cases which aren't covered by this. I'm good with reverting the preflight check for now.

Also wanted to mention that we've invited you to the org, so please check invites!

@shellscape shellscape merged commit 4f4c25d into rollup:master Mar 10, 2021
@benmccann benmccann deleted the ts-upgrade branch March 10, 2021 15:31
@benmccann
Copy link
Contributor Author

Thanks for the invite. Unfortunately I didn't see it in time and the link is only valid for seven days

@shellscape
Copy link
Collaborator

@benmccann I'll send another. please do keep an eye out.

@benmccann
Copy link
Contributor Author

thanks. got it. though I'm not sure I'll have much more time to contribute than I have historically (plus Rich ripped out TypeScript from SvelteKit so not really using this plugin anymore)

@shellscape
Copy link
Collaborator

No worries, it's a no-pressure, as you have time or interest thing. Same goes for all of us. (I take breaks frequently)

@dstaley
Copy link

dstaley commented Mar 10, 2021

Just to verify: I need to wait for a release of this plugin > 8.2.0 before #287 might be resolved, correct? If it isn't, should I file a new issue since #287 was closed/locked?

@beetaa
Copy link

beetaa commented Mar 19, 2021 •
edited
Loading

Just to verify: I need to wait for a release of this plugin > 8.2.0 before #287 might be resolved, correct? If it isn't, should I file a new issue since #287 was closed/locked?

Looking forward to see the result of #287 , too. It would be nice if the next version can be published to npm as soon as possible. Thanks so much.

@beetaa
Copy link

beetaa commented Mar 23, 2021

Just to verify: I need to wait for a release of this plugin > 8.2.0 before #287 might be resolved, correct? If it isn't, should I file a new issue since #287 was closed/locked?

Looking forward to see the result of #287 , too. It would be nice if the next version can be published to npm as soon as possible. Thanks so much.

@shellscape @benmccann waiting for publishing to npm, thanks so much for your jobs.

@Jack-Works Jack-Works mentioned this pull request Jun 1, 2021
Closed
@hotamateurxxx hotamateurxxx mentioned this pull request Jan 7, 2022
Closed
danimoh added a commit to nimiq/ledger-api that referenced this pull request Oct 27, 2024
@danimoh
Update typescript and tslib
77cd7dd 
Also update @typescript-eslint/eslint-plugin, @typescript-eslint/parser and eslint-config-airbnb-typescript
for compatibility with the updated typescript version, and fix newly reported type and lint issues.

Additionally, with the merge of rollup/plugins#818, the rootDir hack for making
typescript build in combination with emitting declaration files could now be removed. For the previous hack
see rollup/plugins#61 (comment) and
rollup/plugins#287.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

Assignees
No one assigned
Labels
🔌 plugin-typescript pr⁴ 🔧 fix
Projects
None yet
Milestone
No milestone
4 participants
@benmccann @shellscape @dstaley @beetaa