This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Handle options.external correctly #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue demonstrated here, wherein a transformed CommonJS module that required
foowould result infoogetting bundled even if it was marked as external withexternal: ['foo'].Unfortunately, we have to achieve this by duplicating some of Rollup's core logic. It might be nice if Rollup exposed certain stuff so that we didn't need to do that. In this case that might mean a
this.isExternal(id)method, rather than us having to recreateisExternal. (This plugin also needs to duplicate resolution logic, but I'm not sure how we could expose that from Rollup in a sane way in this situation.)