Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Specify tsconfig.json file #71

Merged
merged 4 commits into from
May 23, 2017
Merged

Specify tsconfig.json file #71

merged 4 commits into from
May 23, 2017

Conversation

notoriousb1t
Copy link

Allows tsconfig path to be passed into the typescript options. PR for #66

{
    tsconfig: 'path/to/tsconfig.json'
}

@Narretz
Copy link

Narretz commented Nov 22, 2016

It looks like the travis build failed because of a syntax error. Maybe if you fixed it, we could get the maintainer's attention? :D

@notoriousb1t
Copy link
Author

The travis error is because async/await is being used in one of the tests: https://travis-ci.org/rollup/rollup-plugin-typescript/jobs/168521206

When I look at the other PRs for this, they all have the same error. This must have been introduced either by adding a test environment to travis or by a direct commit by the maintainer.

I'm starting to get the sense that this repository has been abandoned due to the lack of activity on it.

@unional
Copy link

unional commented Jan 12, 2017

Does anyone want to pick this up? I also need this PR.

Ping @eventualbuddha @TrySound @maxdavidson

@unional
Copy link

unional commented Jan 12, 2017

@notoriousb1t can you try updating the typescript dependency to 2.1.4? That should solve the travis error.

@notoriousb1t
Copy link
Author

I should be able to do that in a little bit

@unional
Copy link

unional commented Jan 12, 2017

Um... it is complaining the helper methods not generated. Likely need a config file. It should work out of the box. Need to try create a some repo to pin point it.

@unional
Copy link

unional commented Jan 12, 2017

By the way, for now, I'm following this: https://github.com/maxdavidson/typescript-library-boilerplate and it is working well.

@notoriousb1t
Copy link
Author

It looks like this repo is specifying helpers directly, so this PR won't work until this one is accepted https://github.com/rollup/rollup-plugin-typescript/pull/75/files#diff-3ee1ba721a3cf917fc2cf07d504b037a and the code base is remerged

@unional
Copy link

unional commented Jan 12, 2017

Wow, I would expect to use tslib

@PaulBGD
Copy link
Collaborator

PaulBGD commented May 23, 2017

Hello, are you interested in rebasing this off the progress branch? If so I can get it merged in soon.

@notoriousb1t notoriousb1t changed the base branch from master to progress May 23, 2017 06:52
@notoriousb1t
Copy link
Author

@PaulBGD, I swapped the PR over to target the progress branch. I believe this should be good to go.

@PaulBGD PaulBGD merged commit de2a90a into rollup:progress May 23, 2017
@PaulBGD
Copy link
Collaborator

PaulBGD commented May 23, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants