Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make the folds darker then normal text #1

Closed
Industrial opened this issue Aug 12, 2014 · 4 comments
Closed

Suggestion: Make the folds darker then normal text #1

Industrial opened this issue Aug 12, 2014 · 4 comments

Comments

@Industrial
Copy link

Hi.

I've been using this colorscheme with joy but there's one thing in particular that I don't like about it; The color of folds.

I think they are too light. I always like folds to be darker then the normal code in a document, because they hide something rather then highlight it.

http://i.imgur.com/TyRZ4QE.png

vs

http://i.imgur.com/3mngaam.png

gr,

Tom

@romainl
Copy link
Owner

romainl commented Aug 13, 2014

Hi, thank you for the idea.

I've had numerous debates with myself about the actual point of folding: is that a tool to lump together a bunch of lines for further processing (think :folddoclose or :s/foo/bar/g)? Or is that a tool for hiding away code that's meaningless right now? The current highlighting kind of fits the first case because the fold stands out but it stands out a little too much if you find yourself in the second case.

Anyway, thanks again, I'll play with your idea.

@romainl
Copy link
Owner

romainl commented Sep 7, 2014

I've just pushed a new version featuring your changes, tell me how it works for you:

new colors

@romainl
Copy link
Owner

romainl commented Sep 11, 2014

I like it better like that. Case closed.

@romainl romainl closed this as completed Sep 11, 2014
@Industrial
Copy link
Author

Awesome, thanks!

On Thu, Sep 11, 2014 at 10:03 AM, romainl notifications@github.com wrote:

Closed #1 #1.


Reply to this email directly or view it on GitHub
#1 (comment).

vim-scripts pushed a commit to vim-scripts/apprentice.vim that referenced this issue Oct 13, 2014
* The tabline, statusline and vertical split are now visually consistent: "black on ocre" for "active", "ocre on black" for "inactive".
* Following up on issue #1 (romainl/Apprentice#1), folds are darker than they used to be.

Enjoy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants