Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

aar file from maven repo contains app icons #23

Open
claust opened this issue Aug 24, 2015 · 6 comments
Open

aar file from maven repo contains app icons #23

claust opened this issue Aug 24, 2015 · 6 comments

Comments

@claust
Copy link

claust commented Aug 24, 2015

Even though fixed in the Github code, the 1.4.0 aar file that you download from maven.org still contains the ic_launcher.png files.

To verify, please download the aar file directly, unzip it, and see the ic_launcher.png files inside:
http://central.maven.org/maven2/com/romainpiel/shimmer/library/1.4.0/library-1.4.0.aar

Original issue is here: #20

@fimh
Copy link

fimh commented Aug 29, 2015

Yes, claust was right. I also encountered the same problem in 1.4.0.

@Jaymo
Copy link

Jaymo commented Sep 1, 2015

Easiest way to solve this is by adding tools:replace="android:icon" in the application tag of your manifest

@romainpiel
Copy link
Owner

Sorry guys I don't have much time to spend on shimmer at the moment. I'll
try to spend some time this weekend but I can't promise anything.
On 1 Sep 2015 4:42 pm, "James Wahome" notifications@github.com wrote:

Easiest way to solve this is by adding tools:replace="android:icon" in the
application tag of your manifest


Reply to this email directly or view it on GitHub
#23 (comment)
.

@vnh1991
Copy link

vnh1991 commented Nov 17, 2015

@Jaymo

tools:replace="android:icon"

didnt work

@casperbang
Copy link

I also ran into this issue, the ic_launcher was removed from the repository itself but a 1.5 Maven release would be beneficial.

@romainpiel
Copy link
Owner

I don't have much time to spend on Shimmer anymore and it's not a very complex library. Feel free to fork or copy the classes you need into your project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants