Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for JUPYTER_ENABLE_NB #3

Closed
wants to merge 1 commit into from
Closed

Add documentation for JUPYTER_ENABLE_NB #3

wants to merge 1 commit into from

Conversation

3j14
Copy link

@3j14 3j14 commented Jan 10, 2021

Hello,

I've noticed you pull request regarding the transition to JupyterLab and deprecation of Jupyter Notebook.

I've added some documentation including a notice that explains the difference between the two environment variables. Hope this helps ;)

Added documentation in the "Common" section.

Additionally, a few changes had to be made to make the docs compile again. Added Recommonmark's AutoStructify to enable RST in Markdown.
@3j14
Copy link
Author

3j14 commented Jan 10, 2021

Also note that I had to update the docs/conf.py file as there were some issues (newer versions of Sphinx work differntly with Markdown). There was also an issue with a line break in docs/using/selecting.md

@romainx
Copy link
Owner

romainx commented Feb 5, 2022

@jnsdrtlf thanks a lot however we have switched to a different implementation not involving this variable anymore -> jupyter#1575.

Thanks

@romainx romainx closed this Feb 5, 2022
@3j14
Copy link
Author

3j14 commented Feb 5, 2022

No worries! The issue related to this has been resolved anyway :)

@3j14 3j14 deleted the feat-1207-1 branch February 5, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants