chore: code suggestions

crates/rome_analyze/src/lib.rs

@@ -684,7 +684,7 @@ fn update_suppression<L: Language>(
     })
 }
 
-/// Convenient type that to mark a function that is responsible to create a mutation to add a suppression comment.
+/// Payload received by the function responsible to mark a suppression comment
 pub struct SuppressionCommentEmitterPayload<'a, L: Language> {
     /// The possible offset found in the [TextRange] of the emitted diagnostic
     pub token_offset: TokenAtOffset<SyntaxToken<L>>,
@@ -696,6 +696,7 @@ pub struct SuppressionCommentEmitterPayload<'a, L: Language> {
     pub diagnostic_text_range: &'a TextRange,
 }
 
+/// Convenient type that to mark a function that is responsible to create a mutation to add a suppression comment.
 type SuppressionCommentEmitter<L> = fn(SuppressionCommentEmitterPayload<L>);
 
 type SignalHandler<'a, L, Break> = &'a mut dyn FnMut(&dyn AnalyzerSignal<L>) -> ControlFlow<Break>;

crates/rome_analyze/src/rule.rs

@@ -333,7 +333,7 @@ pub trait Rule: RuleMeta + Sized {
     }
 
     /// Create a code action that allows to suppress the rule. The function
-    /// has to return the node to which the suppression comment needs to be applied.
+    /// returns the node to which the suppression comment is applied.
     fn suppress(
         ctx: &RuleContext<Self>,
         text_range: &TextRange,

crates/rome_analyze/src/signals.rs

@@ -76,7 +76,7 @@ where
 
     fn actions(&self) -> AnalyzerActionIter<L> {
         if let Some(action) = (self.action)() {
-            AnalyzerActionIter::new(vec![action])
+            AnalyzerActionIter::new([action])
         } else {
             AnalyzerActionIter::new(vec![])
         }
@@ -141,9 +141,16 @@ impl<L: Language> From<AnalyzerAction<L>> for CodeSuggestionItem {
 }
 
 impl<L: Language> AnalyzerActionIter<L> {
-    pub fn new(actions: Vec<AnalyzerAction<L>>) -> Self {
+    pub fn new<I>(actions: I) -> Self
+    where
+        I: IntoIterator<Item = AnalyzerAction<L>>,
+        I::IntoIter: ExactSizeIterator,
+    {
         Self {
-            analyzer_actions: actions.into_iter(),
+            analyzer_actions: actions
+                .into_iter()
+                .collect::<Vec<AnalyzerAction<L>>>()
+                .into_iter(),
         }
     }
 }

crates/rome_js_analyze/src/lib.rs

@@ -402,7 +402,7 @@ fn apply_suppression_comment(payload: SuppressionCommentEmitterPayload<JsLanguag
                 &JsxAnyChild::JsxExpressionChild(jsx_comment.build()),
             );
         } else {
-            let new_token = current_token.with_leading_trivia(vec![
+            let new_token = current_token.with_leading_trivia([
                 (TriviaPieceKind::Newline, "\n"),
                 (
                     TriviaPieceKind::SingleLineComment,

crates/rome_js_analyze/src/utils/batch.rs

@@ -214,31 +214,22 @@ impl JsBatchMutation for BatchMutation<JsLanguage> {
         after_element: &JsxAnyChild,
         new_element: &JsxAnyChild,
     ) -> bool {
-        let old_list = after_element.syntax().parent().and_then(JsxChildList::cast);
-        if let Some(old_list) = old_list {
-            let jsx_child_list = after_element
-                .syntax()
-                .parent()
-                .map(|parent| {
-                    let list = JsxChildList::cast(parent)?;
-                    let mut new_items = vec![];
-                    for element in list {
-                        new_items.push(element.clone());
-                        if element == *after_element {
-                            new_items.push(new_element.clone());
-                        }
+        let old_list = after_element.parent::<JsxChildList>();
+        if let Some(old_list) = &old_list {
+            let jsx_child_list = {
+                let mut new_items = vec![];
+                for element in old_list {
+                    new_items.push(element.clone());
+                    if element == *after_element {
+                        new_items.push(new_element.clone());
                     }
+                }
 
-                    Some(jsx_child_list(new_items))
-                })
-                .unwrap_or(None);
+                jsx_child_list(new_items)
+            };
 
-            if let Some(jsx_child_list) = jsx_child_list {
-                self.replace_node(old_list, jsx_child_list);
-                true
-            } else {
-                false
-            }
+            self.replace_node(old_list.clone(), jsx_child_list);
+            true
         } else {
             false
         }
@@ -250,30 +241,21 @@ impl JsBatchMutation for BatchMutation<JsLanguage> {
         new_element: &JsxAnyChild,
     ) -> bool {
         let old_list = after_element.syntax().parent().and_then(JsxChildList::cast);
-        if let Some(old_list) = old_list {
-            let jsx_child_list = after_element
-                .syntax()
-                .parent()
-                .map(|parent| {
-                    let list = JsxChildList::cast(parent)?;
-                    let mut new_items = vec![];
-                    for element in list {
-                        if element == *after_element {
-                            new_items.push(new_element.clone());
-                        }
-                        new_items.push(element.clone());
+        if let Some(old_list) = &old_list {
+            let jsx_child_list = {
+                let mut new_items = vec![];
+                for element in old_list {
+                    if element == *after_element {
+                        new_items.push(new_element.clone());
                     }
+                    new_items.push(element.clone());
+                }
 
-                    Some(jsx_child_list(new_items))
-                })
-                .unwrap_or(None);
+                jsx_child_list(new_items)
+            };
 
-            if let Some(jsx_child_list) = jsx_child_list {
-                self.replace_node(old_list, jsx_child_list);
-                true
-            } else {
-                false
-            }
+            self.replace_node(old_list.clone(), jsx_child_list);
+            true
         } else {
             false
         }