Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Formatter: TS Intersection & Union types #3162

Closed
Tracked by #3047
MichaReiser opened this issue Sep 5, 2022 · 3 comments · Fixed by #3177 or #3206
Closed
Tracked by #3047

Formatter: TS Intersection & Union types #3162

MichaReiser opened this issue Sep 5, 2022 · 3 comments · Fixed by #3177 or #3206
Assignees
@denbezrukov
Labels
A-Formatter Area: formatter
Milestone
0.10.0

Comments

@MichaReiser
Copy link
Contributor

No description provided.

@MichaReiser MichaReiser mentioned this issue Sep 5, 2022
Closed
9 tasks
@MichaReiser MichaReiser changed the title TS Intersection & Union types Formatter: TS Intersection & Union types Sep 5, 2022
@MichaReiser MichaReiser added the A-Formatter Area: formatter label Sep 5, 2022
@MichaReiser MichaReiser added this to the 0.10.0 milestone Sep 5, 2022
@denbezrukov
Copy link
Contributor

@MichaReiser Would you mind assigning me this task?

denbezrukov pushed a commit to denbezrukov/tools that referenced this issue Sep 7, 2022
feat(rome_js_formatter): TS Intersection & Union types rome#3162
23e53ea
denbezrukov pushed a commit to denbezrukov/tools that referenced this issue Sep 7, 2022
feat(rome_js_formatter): TS Intersection & Union types rome#3162
9d1489c
denbezrukov pushed a commit to denbezrukov/tools that referenced this issue Sep 7, 2022
feat(rome_js_formatter): TS Intersection & Union types rome#3162
fe72d25
@denbezrukov denbezrukov mentioned this issue Sep 7, 2022
Merged
denbezrukov pushed a commit to denbezrukov/tools that referenced this issue Sep 7, 2022
feat(rome_js_formatter): TS Intersection & Union types rome#3162
d57b748 
format website
denbezrukov pushed a commit to denbezrukov/tools that referenced this issue Sep 7, 2022
feat(rome_js_formatter): TS Intersection & Union types rome#3162
c094167 
format vscode
@denbezrukov
Copy link
Contributor

prettier/prettier#13153
Need to look this issue before implementing union.

MichaReiser pushed a commit that referenced this issue Sep 8, 2022
@denbezrukov
feat(rome_js_formatter): TS Intersection & Union types #3162 (#3177)
6bcf6e8 
Co-authored-by: Denis Bezrukov <dbezrukov@ctrader.local>
@MichaReiser MichaReiser moved this to Done in Rome 2022 Sep 8, 2022
@MichaReiser MichaReiser reopened this Sep 8, 2022
denbezrukov pushed a commit to denbezrukov/tools that referenced this issue Sep 9, 2022
feat(rome_js_formatter): TS Intersection & Union types rome#3162
e315553 
Union types
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
9c790af
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
1aa9365
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
b62d627
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
3104287
@denbezrukov denbezrukov mentioned this issue Sep 12, 2022
Closed
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
0880b87
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
4c8df5f
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
c9cd3e5
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
Formatter: TS Intersection & Union types rome#3162
b9802b4
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
feat(rome_js_formatter): TS Intersection & Union types rome#3162
088041e
@denbezrukov denbezrukov mentioned this issue Sep 12, 2022
Merged
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 12, 2022
@denbezrukov
feat(rome_js_formatter): TS Intersection & Union types rome#3162
460af0d
MichaReiser pushed a commit that referenced this issue Sep 13, 2022
@denbezrukov
feat(rome_js_formatter): TS Intersection & Union types #3162 (#3206)
158f55c
@MichaReiser
Copy link
Contributor Author

prettier/prettier#13153 Need to look this issue before implementing union.

Using a closer formatting to intersection types would be beneficial. Implementing comments around union type feels like a big awful hack source

denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 29, 2022
@denbezrukov
feat(rome_js_formatter): TS Intersection & Union types rome#3162
0d388ac
denbezrukov added a commit to denbezrukov/tools that referenced this issue Sep 29, 2022
@denbezrukov
feat(rome_js_formatter): TS Intersection & Union types rome#3162
538e4fd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@denbezrukov denbezrukov

Labels
A-Formatter Area: formatter
Projects
Rome 2022
Status: Done
Milestone
0.10.0
2 participants
@MichaReiser @denbezrukov