This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our JS Formatter is over-fitting on the test suite and it's very easy to introduce some stability issue when making any change to the formatter/printer.
I was able to narrow down the main sources of the instability issues and fixed them as best I could. However, this PR introduces two regressions that I want to address in follow up PRs.
BestFitting
. See Call expression arguments formatting #2421 for the follow-up PR.This PR removes
HardGroup
s. The main purpose ofHardGroup
s was to more deterministically handle inline comments. This is no longer needed because this PR removes this inline comment printing and we need to come up with a comment printing that doesn't require every node to be wrapped inside of aHardGroup
.The "non-break" behaviour can be achieved by either just creating a sequence of tokens separated by spaces or using
BestFitting
where needed.Test Plan
cargo test