This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_formatter): Part 2: Comments API #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
changed the title
MichaReiser
commented
Sep 16, 2022
| @@ -18,5 +18,9 @@ schemars = { version = "0.8.10", optional = true } | |||
| rustc-hash = "1.1.0" | |||
| countme = "3.0.1" | |||
|
|
|||
| [dev-dependencies] | |||
| rome_js_parser = { path = "../rome_js_parser"} | |||
There was a problem hiding this comment.
I added these dependencies to be able to write tests inside of rome_formatter.
MichaReiser
commented
Sep 16, 2022
| CommentPlacement::Dangling { node, comment } => { | ||
| self.push_dangling_comment(&node, comment) | ||
| } | ||
| CommentPlacement::Default(mut comment) => { |
There was a problem hiding this comment.
These rules are documented in CommentPlacement::Default
MichaReiser
force-pushed
the
refactor/comments
branch
from
68b96aa
to
301ba39
Compare
MichaReiser
force-pushed
the
feat/comments-api
branch
from
ac99767
to
3abdba9
Compare
MichaReiser
force-pushed
the
feat/comments-api
branch
from
3abdba9
to
df087ed
Compare
leops
approved these changes
Sep 19, 2022
ematipico
approved these changes
Sep 19, 2022
Co-authored-by: l3ops <leops@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the Comments refactoring (#3227)
This PR includes the API changes to
Comments.Commentsis the main facade used by formatters and the implementation that extracts comments from a syntax tree.Test Plan
I implemented new test for the builder.