This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_formatter): Part 5: Comments formatting #3243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the comments refactoring #3227.
soft_line_indent_or_spaced
builder that replacesformat_delimited(..).soft_block_or_spaces()
GroupsElementsBuffer
(yay)FormatState
as it is no longer necessary to track the last token to know if spaces must be inserted between the last token and comments (is now the responsibility of the formatter that callsformat_dangling_comments
).Test Plan
Added a doc test for the new
soft_line_indent_or_spaced
builder.