This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_diagnostics): fix the printing of empty diff lines #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3375
This PR fixes a bug that was causing empty inserted or deleted lines to not be displayed by the diff printing logic. Due to the line-based model used to render diffs those lines were considered to have no content, but they should now be properly accounted for.
Test Plan
I've added new test cases to check the insertion and deletion of one or many empty lines are all correctly displayed by the diff printer. I've also updated a few snapshots that were affected by this issue